URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

Label: +Waiting for review

URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

Label: +Changes requested

URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

alexey-tikhonov commented: """

* a socket file descriptor was replaced by 0 (stdin) by a mistake

Thank you, good catch! Fixed.

* I think the 3rd patch could be left out (I like the goto version more for the added "boiler plate" against future mistakes in case we add more code to the function, but that will probably not happen, so I will let Alexey to decide, I am fine either way)

But this is the main purpose of this PR (to reduce covscan complains). So I am looking for a way to please Coverity while keeping "done" section there...

"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-549833970

URL: https://github.com/SSSD/sssd/pull/916 Author: alexey-tikhonov Title: #916: Fix one coverity issue Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/916/head:pr916 git checkout pr916

URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

Label: -Changes requested

URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

mzidek-rh commented: """ Thanks. ACK. """

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-550255907

URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

Label: +Accepted

URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

pbrezina commented: """ * `master` * 3c09e9dceec016c4f31452506d5ddb012f8a82d7 - sss_ssh_knownhostsproxy: fixed Coverity issue * 0102a253eeafee0365f3336ad6bd94606eaf484d - sss_ssh_knownhostsproxy: relocated O_NONBLOCK setting * 24d9d213c0767e1eff5dfbd212d567b2ce1e26d5 - Reduces code duplication

"""

See the full comment at https://github.com/SSSD/sssd/pull/916#issuecomment-551056423

URL: https://github.com/SSSD/sssd/pull/916 Title: #916: Fix one coverity issue

Label: -Accepted

URL: https://github.com/SSSD/sssd/pull/916 Author: alexey-tikhonov Title: #916: Fix one coverity issue Action: closed

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/916/head:pr916 git checkout pr916