This patch should not be pushed to master, but I would like to get it
It should be used to provide a custom build for users experiencing cases
where ldap_search_ext would block (c.f.
would set LDAP_DEBUG_ANY
The attached patch applies cleanly on the RHEL6.1 branch. I also have a
version that applies on master/1.5 if needed.
Here is a bunch of patches for review:
The unit test was not correct. The paths to files used in the unit test
were wrong. It used function exec instead of system which is bad too.
It was hard to see what is going on so some more verbose output added.
The config files are now copied our of the ini.d directory. The
permission test is adjusted.
Can be squashed into previous one but I decided against it as it is a
change in configure.am not in code.
Patch 1 does all the copying of the files used in the unit test so there
is no need to copy file at the configure stage.
Couple convenience functions for the value object that turned out to be
Patches 4-10 (big!!!):
Definition, implementation, unit tests and docs for the new INI
interface that uses value object instead of the bare strings.
There is a lot of code there but it is mostly inspired by existing
interface. It exists in parallel for the backward compatibility.
Old inteface is still built, just not advertised via the docs. It needs
couple more layers of polish before it can be called complete.
The new interface is mostly a copy of the old interface so no big
logical differences other than ability to have keys with multiple values
in the same file.
For example there is now a way to deal with case like this:
and get all the values for key "file" one at a time.
Plans for the near future:
1) Finish the section merge - it is not complete but when it is this
interface will be completely functional. The goal to that during August.
2) Provide a patch for SSSD to switch to the new interface - for August too.
This is the moment when we can call it v1.
Longer term plans:
1) Add functions to create config file to the interface. Currently it is
a the processing/parsing part, but you can't easily construct the
configuration file, only read it.
2) Add validation as it was originally planned.
I will try to find the victim to do the long term changes as I do not
scale for this any more.
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.
Looking to carve out IT costs?
Following the discussion previously for #1476 attached is a patch to
current master that does the following:
1) If there is no value in sssd.conf it assumes a default of 1200 to
fall in line with the current IPA code
2) Adds a new option to sssd.conf - ipa_dyndns_ttl - which is an
integer in seconds for the TTL of the record
I've tested this on F17 with nothing set and with a few different
integers set and verified on IPA (via ipa dnsrecord-show --all) that
the TTL has been set correctly.
Comments would be most welcome :)
Please see the commit. I'm wondering if there is still a (small) race
condition between the call to pthread_cleanup_pop() and unlocking the
mutex. Would it be better to i.e. always call the cleanup handler with
pthread_cleanup_pop(1) and disconnect from the fd based on some other
I know this ticket is scheduled for RC2 but I suspect it is the root
cause of problems we were seeing in production and I wanted to provide a
We always try to resolve the kpasswd server even when we're just
authenticating the user so that tools such as kpasswd work. However, we
should treat errors from this step as fatal only when actually changing
I worked on solution of ticket https://fedorahosted.org/sssd/ticket/1150
and I already had
some solutions with macros, but I found them ugly and obfuscated or not
generic enough, so
they could not be used on all places where we use sysdb_transaction
So I decided not to implement any wrapper macros around these functions
(yet) and only
rewrite the places where we use sysdb_transactions to unify the way they
are used (and to remove bad
examples of usage).
In this patch, I did it for files in src/db/. If this patch is OK, I'll
try to spread this pattern to other modules
where sysdb_transaction_start/commit/cancel is used.
The patch is attached.
NOTE: Function sysdb_idmap_store_mappings looks like completely
rewritten, but it is not. Except of
changes related to sysdb_transaction it had only bad indentation.