URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: opened
PR body: """ The Coding guidelines include the following:
https://docs.pagure.org/SSSD.sssd/developers/coding_style.html MUST: No tabs all indentation 4 spaces.
However, there are places that are indented in 3 spaces or 7 spaces. Unify 3 spaces or 7 spaces indentation to 4 spaces. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/933/head:pr933 git checkout pr933
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/933#issuecomment-552523670
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces
pbrezina commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/933#issuecomment-552838388
URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/933/head:pr933 git checkout pr933
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces
miztake commented: """ Added the following indentation fixes.
- sss_client/sudo/sss_sudo_response.c:199 - providers/ldap/ldap_auth.c:1405 - responder/common/negcache.c:1116 - responder/common/negcache.c:1126 - responder/common/negcache.c:1241 - sss_client/pam_sss.c:2342 """
See the full comment at https://github.com/SSSD/sssd/pull/933#issuecomment-552989985
URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/933/head:pr933 git checkout pr933
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces
miztake commented: """ This PR alone cannot cover the 4 spaces indentation. I'm sorry, but I'll close this PR once and organize it again.
# If you don't like many sources being modified by such PR, don't hesitate to let me know. """
See the full comment at https://github.com/SSSD/sssd/pull/933#issuecomment-553448849
URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/933/head:pr933 git checkout pr933
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces
miztake commented: """ This PR alone cannot cover the 4 spaces indentation. I'm sorry, but I'll close this PR once and organize it again.
If you don't like many sources being modified by such PR, don't hesitate to let me know. """
See the full comment at https://github.com/SSSD/sssd/pull/933#issuecomment-553448849
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces
pbrezina commented: """ I'm fine with fixing the indentation, I just wonder if git can cope with different backspaces when backporting patches? """
See the full comment at https://github.com/SSSD/sssd/pull/933#issuecomment-553473689
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces
pbrezina commented: """ I'm fine with fixing the indentation, I just wonder if git can cope with different spaces when backporting patches? """
See the full comment at https://github.com/SSSD/sssd/pull/933#issuecomment-553473689
sssd-devel@lists.fedorahosted.org
-
centos-ci -
miztake
-
pbrezina