URL: https://github.com/SSSD/sssd/pull/925 Title: #925: src/util/: Propagate error when multiple entries with same certificate have been found

centos-ci commented: """ Can one of the admins verify this patch? """

See the full comment at https://github.com/SSSD/sssd/pull/925#issuecomment-549027603

URL: https://github.com/SSSD/sssd/pull/925 Title: #925: src/util/: Propagate error when multiple entries with same certificate have been found

pbrezina commented: """ Thank you for the contribution. However, I think the issue is more about changing this return code: https://github.com/SSSD/sssd/blob/master/src/responder/common/cache_req/cach...

I.e. if more then one result is found in cache when `only_one_result` is required, return a special error code instead of `ERR_INTERNAL`.

I belive the usecase mentioned in the ticket (user-by-cert lookup in infopipe) is already (covered)[https://github.com/SSSD/sssd/blob/master/src/responder/ifp/ifp_users.c#L373] by 861dbe0794.

"""

See the full comment at https://github.com/SSSD/sssd/pull/925#issuecomment-549333101

URL: https://github.com/SSSD/sssd/pull/925 Author: ikerexxe Title: #925: src/util/: Propagate error when multiple entries with same certificate have been found Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/925/head:pr925 git checkout pr925

URL: https://github.com/SSSD/sssd/pull/925 Title: #925: src/util/: Propagate error when multiple entries with same certificate have been found

pbrezina commented: """ Thank you. Two nitpicks:

Since it is not strictly related to certificates, please change the error message from `Certificate matches multiple user entries` to Multiple objects were found when only one was expected`.

And also change the commit message title from `COMPONENT: src/util/ ` to something like `cache_req: propagate multiple entries error to the caller`.

"""

See the full comment at https://github.com/SSSD/sssd/pull/925#issuecomment-549757058

URL: https://github.com/SSSD/sssd/pull/925 Author: ikerexxe Title: #925: cache_req: Multiple objects were found when only one was expected Action: edited

Changed field: title Original value: """ src/util/: Propagate error when multiple entries with same certificate have been found """

URL: https://github.com/SSSD/sssd/pull/925 Title: #925: cache_req: Multiple objects were found when only one was expected

pbrezina commented: """ Thank you. Ack! """

See the full comment at https://github.com/SSSD/sssd/pull/925#issuecomment-550242932

URL: https://github.com/SSSD/sssd/pull/925 Title: #925: cache_req: Multiple objects were found when only one was expected

Label: +Accepted

URL: https://github.com/SSSD/sssd/pull/925 Title: #925: cache_req: Multiple objects were found when only one was expected

pbrezina commented: """ * `master` * 16be48f4763fcfa79bd7a0eb3af84cd6d36e19c2 - cache_req: propagate multiple entries error to the caller

"""

See the full comment at https://github.com/SSSD/sssd/pull/925#issuecomment-551056222

URL: https://github.com/SSSD/sssd/pull/925 Title: #925: cache_req: Multiple objects were found when only one was expected

Label: -Accepted

URL: https://github.com/SSSD/sssd/pull/925 Author: ikerexxe Title: #925: cache_req: Multiple objects were found when only one was expected Action: closed

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/925/head:pr925 git checkout pr925