sssd-devel October 2014

sssd-devel@lists.fedorahosted.org

16 participants
100 discussions

[PATCH] SUDO: Support the IPA schema
by Michal Šrubař 09 Oct '15

09 Oct '15

Hi guys, I spent some time working at this ticket https://fedorahosted.org/sssd/ticket/1108 and I think it's finally ready to be reviewed by others. Description of the problem and scope of the changes can be found in the commit message. I also wrote some unit tests but the patch is a quite long already so I think it would be better to send the tests as an another patch. Or should I create a patch for each modified file?

4 7

[PATCH] Workaround for dyndns_test_ok failiure on mips(el). Child part has finished before the child handler was created.
by Jurica Stanojkovic 14 Sep '15

14 Sep '15

Hello, Package sssd_1.11.5.1-1 on Debian FTBFS for mips and mipsel. https://buildd.debian.org/status/fetch.php?pkg=sssd&arch=mips&ver=1.11.5.1-… https://buildd.debian.org/status/fetch.php?pkg=sssd&arch=mipsel&ver=1.11.5.… dyndns_test_ok is failing with following log: [ RUN ] dyndns_test_ok(Tue Jul 8 15:53:55:004476 2014) [sssd] [be_nsupdate_args] (0x0200): (Tue Jul 8 15:53:55:004521 2014) [sssd] [child_handler_setup] (0x2000): nsupdate auth type: GSS-TSIGSetting up signal handler up for pid [21397](Tue Jul 8 15:53:55:004693 2014) [sssd] [__wrap_execv] (0x0200): nsupdate success test case(Tue Jul 8 15:53:55:004825 2014) [sssd] [__wrap_execv] (0x1000): Child exiting with status 0(Tue Jul 8 15:53:55:005275 2014) [sssd] [child_handler_setup] (0x2000): Signal handler set up for pid [21397](Tue Jul 8 15:54:55:837623 2014) [sssd] [write_pipe_handler] (0x0020): write failed [32][Broken pipe].(Tue Jul 8 15:54:55:837801 2014) [sssd] [nsupdate_child_stdin_done] (0x1000): Sending nsupdate data complete(Tue Jul 8 15:54:55:837869 2014) [sssd] [nsupdate_child_stdin_done] (0x0040): Sending nsupdate data failed [32]: Broken pipe(Tue Jul 8 15:54:55:837947 2014) [sssd] [be_nsupdate_done] (0x0040): nsupdate child execution failed [1432158228]: Dynamic DNS update failed(Tue Jul 8 15:54:55:837985 2014) [sssd] [dyndns_test_ok] (0x1000): Child request returned [1432158228]: Unknown error 14321582280x555d0014 != 0../src/tests/cmocka/test_dyndns.c:222: error: Failure![ FAILED ] dyndns_test_okChild part has finished before the child handler was created. I have created and attached a patch which is workaround for this issue. Could someone please take a look and comment this? Thank you! Sincerely, Jurica

4 6

[PATCH] DYNDNS: Add a new option dyndns_server
by Jakub Hrozek 28 Jul '15

28 Jul '15

Hi, one of our users ran into an interesting problem -- her AD infrastructure was different from the DNS server. Because by default, we perform update against the server we're connected to, the DNS update didn't work. Per Simo's suggestion, I've implemented a new option that allows the administrator to override the DNS server used for DNS updates.

4 5

[PATCHES] AUDIT: Add audit support for SSSD
by Michal Židek 21 Jul '15

21 Jul '15

These two patches are initial patches for tickets https://fedorahosted.org/sssd/ticket/2373 https://fedorahosted.org/sssd/ticket/2372 I will add wrappers for more libaudit functions as needed in later patches. As for now, the audit support is not build by default so you need to run --with-libaudit. I would like to make it default when we have the above tickets solved. Thanks, Michal

2 5

[PATCH] Monitor and sbus changes for running SSSD as a non-privileged user
by Jakub Hrozek 27 Jan '15

27 Jan '15

Hi, Attached are patches that perform changes in the monitor process and the low-level sbus and sysdb code required to run the NSS responder as a non-privileged user. Some of the patches call chmod/chown on files owned by the SSSD, so I'd like to request a very careful review. The patches depend on patches from threads: * SSSD: Add the options to specify a UID and GID to run as * Packaging fixes related to non-root SSSD I tried to explain the changes well in the commit messages. See below for some more and especially questions. [PATCH 1/7] SSSD: Load a user to run a service as from configuration Pretty much just loads the sssd user from configuration and stores the uid/gid. One question -- should the individual services or domain have a option to ignore the sssd user? For instance: [sssd] user = sssd group = sssd [nss] # Would run as SSSD [pam] # Would run as root/whatever user monitor runs as ignore_sssd_user = True This would mostly be a fallback for cases where we introduce a bug. I don't think this kind of granularity is needed, the user can just run sssd as root completely: [sssd] user = root group = root [PATCH 2/7] SBUS: Chown the sbus socket if needed Chowns the monitor sbus socket if a non-root sssd user is specified. I don't think we allow more privileges than before, the monitor socket has permissions 0600 and is owned by sssd.sssd, so only the private user and root (who bypasses DAC checks anyway) can access it. In sbus_new_server(), we can open the socket after dbus creates it and call fchmod() and fchown() to avoid some kind of TOCTOU races. But I'm not sure this is needed given that a privileged process will create the pipes. [PATCH 3/7] SBUS: Allow connections from other UIDs A simple patch, allows connections from the sssd user. Please see the commit message for more details. This patch (and the previous) should have a unit test, but currently our sbus tests are tightly tied to the check framework. I need to change the common code to be test framework-agnostic, but I don't want to delay the inclusion of these patches. [PATCH 4/7] BE: Own the sbus socket as the SSSD user Same as the two previous patches, just for the sssd_be process. [PATCH 5/7] MONITOR: Allow confdb to be accessed by nonroot user Confdb is created by the privileged monitor process, but needs to be accessed by nonprivileged responder processes. chown it after creation. [PATCH 6/7] SYSDB: Allow calling chown on the sysdb file from monitor Same as the previous one, just for the sysdb. [PATCH 7/7] NSS: Run as a user specified by monitor With this patch, it's possible to run the NSS responder as a non-privileged user.

4 38

[patch] Python 3 support for sssd
by Bohuslav Kabrda 13 Jan '15

13 Jan '15

Hey all, for past few days, I've been working on python3-compat patch for sssd. The patch [1] is attached to the issue that requests this feature [2]. Some comments: - The patch tries to maintain backward compatibility for Python 2.6 and 2.7 - I admit I only tested 2.7 so far, but it seemed to work ok. - I didn't yet solve the build part - for now, I just handedit configure.ac to set "PYTHON=python3" and src/external/python.m4 to set "AC_PATH_PROG(PYTHON, python3)" and compile with that. - I managed to run Python tests in src/tests except python-test.py itself (it says "OSError: [Errno 5] Could not initialize connection to the confdb" and I didn't yet investigate why that happens). - To run tests, one must modify the hashbangs to /usr/bin/python3 (I now see that I left one of these in the actual patch, so please disregard that). I'd like to ask you, sssd devels, to give me some comments on the patch (or ask questions) and if you have some time to spare, doing more extensive testing would also be very welcome. -- Regards, Bohuslav "Slavek" Kabrda. [1] https://fedorahosted.org/sssd/attachment/ticket/2017/sssd-python3-compat.pa… [2] https://fedorahosted.org/sssd/ticket/2017

2 11

[PATCHES] Sig handlers cleanups
by Simo Sorce 12 Jan '15

12 Jan '15

While checking if our custom signal handlers properly handle errno, I stumbled on a few cleanups, they are attached. turns out our few signal hanlders are errno safe, and tevent signal handling function is also fine. Simo. -- Simo Sorce * Red Hat, Inc * New York

5 17

[PATCH] SYSDB: sysdb_search_object_by_sid returns ENOENT
by Pavel Reichl 17 Dec '14

17 Dec '14

Hello, please see attached patch. This patch is part of solution for https://fedorahosted.org/sssd/ticket/1991 which aims to unify return values of sysdb calls in case no results are found. Thanks!

4 23

[PATCH] LDAP: Do not clobber return value when multiple controls are returned
by Jakub Hrozek 09 Dec '14

09 Dec '14

Hi, please see the attached patch and its commit message. An alternative might be to use a different variable for the result (as we did in 1.9) before the new error codes.

2 3

[PATCH] simple access provider - don't fail on non-existing objects
by Pavel Reichl 08 Dec '14

08 Dec '14

Hello, I noticed that if using simple access provider and having non-existing group or user in access/deny list then access will be denied and "su: System error" will be printed. I think it's OK to simply skip non-existing objects on allow_list. I'm not so sure what to do in case of deny lists. Should we also just skip them or should we deny the user and print more appropriate message ("su: Permission denied")? Thanks, PR

6 15

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel October 2014