[INI] Patches for ding-libs: Merging config sections, handling metadata, remaining Coverity issues...
by Dmitri Pal
Please see the attached patches. I tried to split the patches logically
into manageable sets.
Unfortunately I made a minor mistake and I am afraid I will do something
wrong to fix it.
I merged two wrong patches. Fortunately it was three liner with 1 liner
so it is not a big of the deal but I am really scared that I will do
something wrong and loose the work I have done.
So I hope it is Ok to send it as is.
0001--INI-Making-Coverity-happy.patch <- this is the patch I submitted
earlier that I merged by mistake. I was supposed to merge it with patch
25 but picked the wrong one instead.
Patch 25 addresses the real issue found by Coverity as mentioned in
Stephen's review mail but it did not apply cleanly since it relies on
some code from the patches in the middle.
0002--INI-Adding-missing-function-declararion.patch <- this is the
patch that was rejected from the second set sent earlier. Fixed
according to review comment.
0003--BUILD-Allow-trace-per-component.patch <- This patch allows tracing
per component
The following set of patches introduces the merging of sections during
the reading of the file:
0004--INI-New-error-codes-and-messages.patch
0005--INI-New-merge-flags.patch
0006--INI-Add-new-vars-to-parse-structure.patch
0007--INI-Add-save_error-function.patch
0008--INI-Change-parse_error-to-use-save_error.patch
0009--INI-Preparing-for-merging-sections.patch
0010--INI-Enhance-value-processing.patch
0011--INI-Use-section-line-number.patch
0012--INI-Refactor-section-processing.patch
0013--INI-Return-error-in-DETECT-mode.patch
0014--INI-New-test-files-for-section-merge.patch
0015--INI-Test-DETECT-mode-and-use-new-file.patch
0016--INI-Test-for-all-section-merge-modes.patch
Patches related porting of the meta data from old way of doing things to
the new way of doing things:
0017--INI-Separate-close-and-destroy.patch
0018--INI-Function-to-reopen-file.patch
0019--INI-Metadata-collection-is-gone.patch
0020--INI-Check-access-function.patch
0021--INI-Avoid-double-free.patch <- patch related to 17 (missed check)
0022--INI-Function-to-check-for-changes.patch
0023--INI-Tests-for-access-and-changes.patch
0024--INI-Rename-error-print-function.patch <- rename error printing
function for consistency with new interface
0025--INI-Initialize-variables-in-loops.patch <- Coverity issue
addressed. Related to patch 0001.
0026--INI-Exposing-functions.patch <- Make some internal functions reusable
There is also patch 27. It is a piece of new functionality. It is a
preview. Please see the comment before reviewing it.
Do I need to split it into multiple patches or it is Ok as is? It is
pretty big but all changes are in one file and logically related.
The UNIT test is missing so I am not claiming it actually works as
expected.
--
Thank you,
Dmitri Pal
Sr. Engineering Manager IPA project,
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
11 years, 8 months
[PATCHES] Various ding-lib fixes
by Sumit Bose
Hi,
this series of patches fixes some issues in ding-libs. Patch 0003 should
fix Coverity issues 10035-10040 and 0004 and 0005 the remaining open
issues.
bye,
Sumit
12 years, 8 months
[PATCH] Reset server status after timeout
by Jakub Hrozek
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
https://fedorahosted.org/sssd/ticket/809
When resetting a port status, check a timeout, if it passed, also reset
the server status which will trigger a hostname lookup next time.
I also noticed we had a bug in get_server_status() - we were always
setting last_status_change to the start of the Epoch.
Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk1rcTwACgkQHsardTLnvCVv3ACdH20Bu5HzyT9MS9lr+CNnabYm
ZIIAnAxSzV70+zNiRob6iv8Xu7udQFHQ
=X9PC
-----END PGP SIGNATURE-----
12 years, 9 months
user groups may not contain user's entry
by Sergei V. Kovylov
Hi all.
I've noticed that sssd has incorrect behavior with different versions of LDAP.
The issue is because of LDB store each entry in case sensitive format,
but there's no difference for LDAP, so if we have in LDB database:
user's entry:
dn: uid=user,ou=GROUP,dc=domain
...........
and user's group entry:
dn: cn=group,OU=GROUP,dc=domain
member: uid=user,OU=GROUP,dc=domain
.....
then user "user" will never be a part of group "group" as entries
"uid=user,ou=GROUP,dc=domain" and "uid=user,OU=GROUP,dc=domain" are
not equal(in LDB logic).
I've noticed this when had migrated from FDS v.1.2.3 to FDS v.1.2.7.5
as last one converting DN attibutes to lower case, but provide value
of "uniquemember" as is.
You will find a patch to fix this on sssd side in attach.
12 years, 9 months
[PATCH] Fix uninitialized value error in ipa_get_id_options()
by Stephen Gallagher
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Previously, we were only constructing the basedn variable if the
ldap_search_base was not specified (which is unlikely to be in use
when using the IPA provier). However, if it did happen,
constrcuction of the compat search base for netgroups would be
using an uninitialized value.
Fixes https://fedorahosted.org/sssd/ticket/806
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk1j4CQACgkQeiVVYja6o6MMGQCgr6rQqpXCcxkCAQQNm+knqcwH
VPwAn17U3bp/2Xkfhu4uPKeoIvXcpFUW
=4xxN
-----END PGP SIGNATURE-----
12 years, 9 months