sssd-devel November 2013

sssd-devel@lists.fedorahosted.org

18 participants
68 discussions

[PATCHES] Sig handlers cleanups
by Simo Sorce 12 Jan '15

12 Jan '15

While checking if our custom signal handlers properly handle errno, I stumbled on a few cleanups, they are attached. turns out our few signal hanlders are errno safe, and tevent signal handling function is also fine. Simo. -- Simo Sorce * Red Hat, Inc * New York

5 17

[PATCH] krb5: Check return value of sss_krb5_princ_realm
by Lukas Slebodnik 28 Nov '14

28 Nov '14

ehlo, yet another warning from clang static analyser. sss_krb5_princ_realm set output parameter realm to NULL and len to 0 in case of failure. Clang static analysers repoted warning "Null pointer passed as an argument to a 'nonnull' parameter" in function match_principal. It was possible, that realm_name with value NULL could be used in strncmp. Function sss_krb5_princ_realm is used on other places for printing(formatting) realm_name and NULL can be safely used as a argument for printf-like functions. Patch is attached. LS

5 13

[PATCH] LDAP: Try all attributes when saving an entry
by Jakub Hrozek 08 Jul '14

08 Jul '14

Hi, this bug was reported on #sssd by a user. He was running some flavor of IBM Tivoli where the entries only had an "ID", not separate "UID" and "GID". But due to a bug in sssd he couldn't use the same value for both, this configuration: ldap_user_uid_number = idAttribute ldap_user_gid_number = idAttribute only saved the ID into UID and left GID empty. It appears we have a long standing bug in sdap_parse where we only consider first match. If this patch is accepted, I would also like to refactor sdap_parse in master because currently it is a 250-lines long function with multiple branches..

2 6

Build Fixes
by Benjamin Franzke 17 May '14

17 May '14

Hi, These two patches add missing CFLAGS/LIBS to Makefile.am: [PATCH 1/2] BUILD: Link libsss_ad.so to sasl libs [PATCH 2/2] BUILD: Use OPENLDAP_CFLAGS instead of LDAP_CFLAGS This underlinking was noticed in make check (dlopen-test). Note: It failed for me since my openldap build had no sasl support, which would otherwise have pulled in libsasl2.so. Of course, that support should be in place, but the linking should still be fixed. BTW: It would propably be nice to have a configure check whether openldap has sasl support, but it seems that would need a check if ldap_sasl_interactive_bind returns LDAP_NOT_SUPPORTED. Regards, Ben

6 13

[PATCH] BUILD: Link libsss_krb5_common.so to libkeyutils.so
by Benjamin Franzke 28 Apr '14

28 Apr '14

Hi List, The symbol add_key is used by src/providers/krb5/krb5_delayed_online_authentication.c which is part of libsss_krb5_common.so Fixes following error: [sssd[be[default]]] [load_backend_module] (0x0010): Unable to load ad module with path (/usr/lib64/sssd/libsss_ad.so), error: /usr/lib64/sssd/libsss_krb5_common.so: undefined symbol: add_key -lkeyutils was passed to the libraries libsss_{krb5,ipa,ad}.so, but when compiling with -Wl,--as-needed this flag will be ignored, since it is not used directly. So it was unavailable to libsss_krb5_common.so which actually needs it. This patch removes $(KEYUTILS_LIBS) from those libraries and adds it to libsss_krb5_common.so Maybe libsss_krb5_common.so should be added to dlopen-tests? But then other libraries and functions are needed as well, which it currently inherits from libsss_{krb5,ipa,ad}.so. BTW: are these common libraries (i mean ldap too) convenience build libraries, or to save disk space? If they're just for convencience maybe they should not be installed? Regards, Ben

4 16

[PATCH] TESTS: Link libsss_test_common with tevent
by Lukas Slebodnik 10 Mar '14

10 Mar '14

ehlo, Static library libsss_test_common calls tevent functions directly (in module common_tev.c), but it was not linked with tevent library. Compilation will fail if sssd is linked with "-Wl,--as-needed" CCLD test_utils /usr/bin/ld: ./.libs/libsss_test_common.a(common_tev.o): undefined reference to symbol 'tevent_context_init@@TEVENT_0.9.9' /usr/bin/ld: note: 'tevent_context_init@@TEVENT_0.9.9' is defined in DSO /usr/lib/gcc/x86_64-redhat-linux/4.8.2/../../../../lib64/libtevent.so so try adding it to the linker command line /usr/lib/gcc/x86_64-redhat-linux/4.8.2/../../../../lib64/libtevent.so: could not read symbols: Invalid operation clang: error: linker command failed with exit code 1 (use -v to see invocation) nm ./libsss_test_common.a | grep tevent U tevent_context_init U _tevent_loop_once U _tevent_req_create U _tevent_req_done U _tevent_req_error U tevent_req_is_error U tevent_req_post Simple patch is attached. LS

2 9

[PATCH] nested groups unit test
by Pavel Březina 18 Feb '14

18 Feb '14

Hi, this is the first unit test for nested groups. It covers only the most basic situation when we are trying to resolve one group with no members. Even though it is only one test, the patch set is quite big. This is because it creates the possibility to mock providers related modules. Most of the patches are just a preparation for unit testing providers. Patches 1-5 Moves the code around to reduce number of dependencies. (E.g. you do not want to load fail over when you are testing nested groups.) Patch 6 Mocks basic SDAP interface. Patch 7 Mocks sysdb objects - currently user and rfc2307bis group. You can decide what set of attributes the object should posses. For example, creating a user requires only basedn and name parameter, to construct originalDN and name attributes. The rest is provided by (attrname, value) pairs via variadic function. E.g.: mock_sysdb_user(mem_ctx, basedn, name, SYSDB_UIDNUM, uid, ...) get_attr_type() translates the sysdb attribute name to proper data type. This should be extended as needed. Patch 8 Adds provider tests related common object files and cflags in makefile Patch 9 New macro sss_will_return_always(fn, value). This can be used to mock function data in such way that any call of mock() will return the value. It was just pushed also to cmocka upstream as will_return_always(). Patch 10-11 Unit test. Patch 12 Removes a noisy debug message. I would like to get this reviewed before I continue with more test cases, so the framework is tuned enough. Off topic: I also created new macro called fail_msg, which will make the test fail printing a message. I didn't use this macro in the end, but it made its way to cmocka upstream.

3 10

[PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.
by Michal Židek 05 Feb '14

05 Feb '14

On 11/14/2013 01:14 PM, Lukas Slebodnik wrote:>>From >> >- ((uint32_t *)body)[0] = num-skipped; /* num results */ >> >- ((uint32_t *)body)[1] = 0; /* reserved */ >> >+ SAFEALIGN_SETMEM_UINT32(body, num - skipped, NULL); /* num results */ >> >+ SAFEALIGN_SETMEM_UINT32(body + sizeof(uint32_t), 0, NULL); /* reserved */ > Here is an conflict due to patch "NSS: Set packet length for initgroups" Resolved. > >> > >> > return EOK; >> >} New patch is attached. Michal

3 13

[INI][PATCHES] All of them (C-Style Comments, Unicode conversion, Space processing, UNIT tests)
by Dmitri Pal 10 Jan '14

10 Jan '14

Hello, This mail contains all the patches that I have so far in my git. -------------------------- The following set of patches is related to comments and unchanged from the previous submission. I replied to the comments about them in another mail. I do not think there is anything to address. If there is please let me know. 0001-INI-Do-not-check-validity-of-comments.patch 0002-INI-Extend-error-set-and-add-parsing-error.patch 0003-INI-Process-c-style-comments.patch 0004-INI-Test-files-for-unit-test.patch 0005-INI-Unit-test-for-c-style-comments.patch -------------------------- The following set of patches addresses comments and fixes bugs in Unicode/UTF8 conversion 0006-INI-Expose-buffer-context-as-void.patch 0007-INI-Extend-internal-file-handle.patch 0008-INI-Convert-files-to-UTF.patch 0009-INI-Updated-unit-test-for-UTF8-conversion.patch Thanks for review Lukas. I reworked the code significantly. I think I addressed everything except the initialization comment. I agree with you that it would have been better to initialize things outside the loop but I need to read the first buffer to be able to determine the encoding. This is what causes this logic. I do not see a way to avoid it so left that part as is. ---------------------------- The following one liner fixes a trace text 0010-INI-Fix-typo-in-comment.patch ---------------------------- The following patches are related to the problem I noticed earlier and recorded in the ticket https://fedorahosted.org/sssd/ticket/2119 But in reality the cause was bug in the Unicode conversion and a bug with space processing. 0011-INI-Fix-processing-of-the-white-space-at-the-end-of-.patch 0012-INI-Unit-test-for-space-trimming-in-multiline-values.patch ---------------------------- The following patch adds more unit test for both Unicode conversion and folding by combining the tests together. The unit tests written for each of them individually are not sufficient to catch corner cases. This test does. And I played with different constants before checking in to make sure that all sorts of combinations are caught. I decided to settle on these numbers because they provide sufficient amount of testing but do not extend the time too much. Right now all make check tests take about 7-8 seconds on my laptop. 0013-INI-Adding-more-unit-tests.patch -- Thank you, Dmitri Pal Sr. Engineering Manager for IdM portfolio Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

3 9

[Patch] Cmocka unit test patch for authtok module
by Pallavi Jha 09 Jan '14

09 Jan '14

Hi I have created the patch and attached it with this mail. Kindly review it. I have commented some of the test as it fails(gives segmentation fault) when authtoken is NULL. I think we should test tok for NULL before accessing its elements. Please correct me if am wrong. for example : uint8_t *sss_authtok_get_data(struct sss_auth_token *tok) { return tok->data; } This should be written as: uint8_t *sss_authtok_get_data(struct sss_auth_token *tok) { if(!tok) { return EINVAL; } return tok->data; } Thanking You, Pallavi

4 18

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel November 2013