sssd-devel June 2013

sssd-devel@lists.fedorahosted.org

22 participants
86 discussions

Start a nNew thread

[PATCH] Add ldap_autofs_map_master_name option
by C. S. 12 Nov '13

12 Nov '13

Add ldap_autofs_map_master_name option so that the auto master map name change be changed from the default auto.master.

3 17

[PATCH] Removing unused parameter type from sudosrv_get_sudorules_query_cache()
by Lukas Slebodnik 28 Aug '13

28 Aug '13

Hi, this patch should solve ticket https://fedorahosted.org/sssd/ticket/1825 LS

3 5

[PATCH] Use conditional build for retrieving ccache.
by Lukas Slebodnik 22 Aug '13

22 Aug '13

ehlo, Sumit wrote me yesterday, that some krb5 functions in get_ccache_name_by_principal needn't be available in older version of libkrb5. We noticed that this function is very similar to another function get_ccache_for_princ and there was used conditional build. Refactoring patch is attached. LS

2 5

[PATCH] print password complexity hint when change password failed
by Pavel Březina 11 Aug '13

11 Aug '13

Now the output looks like: $ su test-user Password: Password expired. Change your password now. Current Password: New password: Retype new password: Password change failed. Please make sure the password meets the complexity constraints. su: incorrect password

3 8

[PATCH] init script: source /etc/sysconfig/sssd
by Pavel Březina 08 Aug '13

08 Aug '13

https://fedorahosted.org/sssd/ticket/1959 Is there anyway how to achieve this in systemd? Do we want the path configurable?

4 10

[PATCHES] Do not call sss_cmd_done in function check_cache
by Lukas Slebodnik 08 Aug '13

08 Aug '13

ehlo, Attached patches should fix https://fedorahosted.org/sssd/ticket/1980 The first patch adds check after sysdb_getnetgr. If sysdb_getnetgr returns more result than 1, sssd will return error. sysdb_getpwnam has already had this check. The second patch removes function call sss_cmd_done inside of check_cache, because function is sss_cmd_done is called in parent functions. This was a reason of sssd crash. How to reproduce this crash. 1.Add Netgroup to sysdb cache with base cn=Netgroups,cn=<domain>,cn=sysdb This netgroup should have the same attribute (name or nameAlias or memberOf) as another netgroup. 2. call sudo with user, which is member of ^^^ netgroup. Those patches fix only sssd crash, but we should find out: Why were those netgroups stored in sysdb. LS

2 7

[PATCH] Change order of libraries in linking process.
by Lukas Slebodnik 22 Jul '13

22 Jul '13

ehlo, It seems that some linkers have problem with wrong order of libraries. This commit only change order. Attached patch should fix next issue: Library libsss_crypt.so is used in linking process, but there are undefined references. It seems that I changed order of libraries after rewriting link_all_deplibs patch to use automake variable SSSD_INTERNAL_LTLIBS. I only tested new patch with patched version of libtool on fedora. libtool: link: gcc -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Werror-implicit-function-declaration -fno-strict-aliasing -std=gnu99 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -I/usr/include/samba-4.0 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o .libs/sss_ssh_authorizedkeys src/sss_client/sss_ssh_authorizedkeys-common.o src/sss_client/ssh/sss_ssh_authorizedkeys-sss_ssh_client.o src/sss_client/ssh/sss_ssh_authorizedkeys-sss_ssh_authorizedkeys.o -lpthread -ltalloc /usr/lib/x86_64-linux-gnu/libpopt.so ./.libs/libsss_crypt.so ./.libs/libsss_debug.so ./.libs/libsss_child.so ./.libs/libsss_util.so -Wl,-rpath -Wl,/usr/lib/x86_64-linux-gnu/sssd ./.libs/libsss_util.so: undefined reference to `sss_base64_decode' ./.libs/libsss_util.so: undefined reference to `s3crypt_gen_salt' ./.libs/libsss_util.so: undefined reference to `sss_base64_encode' ./.libs/libsss_util.so: undefined reference to `s3crypt_sha512' collect2: error: ld returned 1 exit status LS

3 3

[PATCH] Do not try to set password when authtok_length is zero
by Ondrej Kos 18 Jul '13

18 Jul '13

The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string. When password is empty, it passes 0 as length, which is misinterpreted, and the function tries to determine the length of string by itself, reaching over boundaries of authtok string. trac issue: https://fedorahosted.org/sssd/ticket/1814 Patch is attached Ondra -- Ondrej Kos Associate Software Engineer Identity Management - SSSD Red Hat Czech

5 14

[PATCH] fix dyndns crash on timeout
by Pavel Březina 17 Jul '13

17 Jul '13

Unfortunately, the reported did not provide logs from the time of crash. The backtrace only says that it occurred in nsupdate_child_handler() but I'm very confident that the root cause was that the dyndns update reached timeout. The first patch fixes dyndns unit tests to actually reveal the crash. Cooler solution would be to use tevent_loop_wait(), but it contains an issue due to which it is not possible. This issue was reported on Samba mailing list: https://lists.samba.org/archive/samba-technical/2013-June/093457.html Second patch will fix the crash. What is the difference between child_sig_handler() which uses context suffixed with _old and sss_sigchld_init()? Would it make sense to update the code to the new sigchld handler?

2 4

[PATCH] Return right directory name for dircache
by Lukas Slebodnik 10 Jul '13

10 Jul '13

ehlo, Dircache can be either file or directory. Wrong value was used when dircache was itself directory. https://fedorahosted.org/sssd/ticket/2002 Patch is attached. LS

2 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel June 2013