URL: https://github.com/SSSD/sssd/pull/175
Author: lslebodn
Title: #175: Add module for starting services
Action: opened
PR body:
"""
This is a WIP version of reducing code duplication in our cwrap integration tests.
I am still not sure whether we should also reuse function `create_sssd_fixture`.
And if yes; then probably in different nodule then `services`
And comments are welcome.
BTW I wrote patches few weeks ago; therefore new tests are not converted.
I am just sending patches to get some feedback.
Site effect of this patches is that tests are cca 20% faster (IIRC)
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/175/head:pr175
git checkout pr175
URL: https://github.com/SSSD/sssd/pull/5434
Author: sidecontrol
Title: #5434: Adding multihost tests for ad_allow_remote_domain_local_groups, bz1883488 bz1756240
Action: opened
PR body:
"""
This is the first multihost test that requires more than one AD server, it requires a root, child and tree domain and users created from the playbooks in CI.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5434/head:pr5434
git checkout pr5434
URL: https://github.com/SSSD/sssd/pull/5636
Author: sergiodj
Title: #5636: Improve assertion when verifying paths for Python modules
Action: opened
PR body:
"""
In Ubuntu we're facing a problem where the 3 Python tests under
src/tests/*-test.py are failing due to cosmetical differences between
what the '.__file__' method returns and what 'MODPATH' ends up being.
I have not been able to pinpoint exactly what is causing this issue;
it only happens when SSSD is built inside a chroot environment (with
sbuild, for example). The logs look like this:
```python
F
======================================================================
FAIL: testImport (__main__.PyHbacImport)
Import the module and assert it comes from tree
----------------------------------------------------------------------
Traceback (most recent call last):
File "/<<PKGBUILDDIR>>/src/tests/pyhbac-test.py", line 91, in testImport
self.assertEqual(pyhbac.__file__, MODPATH + "/pyhbac.so")
AssertionError: '/<<PKGBUILDDIR>>/build/./tp_pyhbac_xw2omut2/pyhbac.so' != './tp_pyhbac_xw2omut2/pyhbac.so'
- /<<PKGBUILDDIR>>/build/./tp_pyhbac_xw2omut2/pyhbac.so
+ ./tp_pyhbac_xw2omut2/pyhbac.so
```
Given that the intention of the test is to verify that the two paths
are equal, I suggest that we do this slight improvement and call
'os.path.realpath' before comparing both paths. This way we guarantee
that they're both properly canonicalized.
I have verified that the tests still pass with this change.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5636/head:pr5636
git checkout pr5636
URL: https://github.com/SSSD/sssd/pull/5651
Author: mtorromeo
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests
Action: opened
PR body:
"""
Since 2.5.0 I had these 3 tests fail with the following assertion error:
```
======================================================================
FAIL: testImport (__main__.PyHbacImport)
Import the module and assert it comes from tree
----------------------------------------------------------------------
Traceback (most recent call last):
File "/build/sssd/src/sssd-2.5.0/src/tests/pyhbac-test.py", line 91, in testImport
self.assertEqual(pyhbac.__file__, MODPATH + "/pyhbac.so")
AssertionError: '/build/sssd/src/sssd-2.5.0/./tp_pyhbac_za3ox6lp/pyhbac.so' != './tp_pyhbac_za3ox6lp/pyhbac.so'
- /build/sssd/src/sssd-2.5.0/./tp_pyhbac_za3ox6lp/pyhbac.so
+ ./tp_pyhbac_za3ox6lp/pyhbac.so
```
I don't know what changed but the issue here is related to a long-standing bug [1] in `tempfile.mkdtemp` where the returned path is not absolute if the dir parameter is relative, despite the documentation saying that the returned path is always absolute.
[1] https://bugs.python.org/issue7325
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5651/head:pr5651
git checkout pr5651
URL: https://github.com/SSSD/sssd/pull/844
Author: mastersin
Title: #844: sssd-ad and gpo_child: GPO apply fixes during reading fails
Action: opened
PR body:
"""
Ignore AD GPO errors:
- if SecEdit/GptTmpl.inf is missing
or
- if reading sysvol_gpt_version fails and cached_gpt_version already exists
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/844/head:pr844
git checkout pr844
URL: https://github.com/SSSD/sssd/pull/5591
Author: aborah-sudo
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Action: opened
PR body:
"""
This script will contain many regression of shadow utils Bzs.
This is part 1 of that.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5591/head:pr5591
git checkout pr5591
URL: https://github.com/SSSD/sssd/pull/5654
Author: sumit-bose
Title: #5654: test: replace deprecated libcheck macros
Action: opened
PR body:
"""
The fail* macros are deprecated by libcheck some time ago. Recently a fix
for a different issue in those macros cause a 'too many arguments for
format' compiler warning which won't be fixed on the libckeck side since
the macros are deprecated.
This patch replaces the deprecated macros with the new ones:
- fail -> ck_abort_msg
- fail_unless -> ck_assert_msg
- fail_if -> sss_ck_fail_if_msg
The fail_if macro does not have a corresponding new version and I added a
local replacement sss_ck_fail_if_msg which is based on ck_assert_msg.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5654/head:pr5654
git checkout pr5654