On (08/12/14 14:19), Dmitri Pal wrote:
On 12/08/2014 01:10 PM, Pavel Březina wrote:
>On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
>>On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
>>>On 12/07/2014 05:32 PM, Dmitri Pal wrote:
>>>>Hello,
>>>>
>>>>First three patches introduce changes to collection that were needed
>>>>for
>>>>the implementation of the INI object modification API
>>>>The rest are for the INI itself. I made recommended changes and
>>>>cleaned
>>>>doxygen comments a bit.
>>>>
>>>>The INI interface so far does not include:
>>>>a) Saving to file - function requested by Pavel
>>>>b) Sorting
>>>>
>>>>I plan to provide this functionality in the follow up patches.
>>>>
>>>Cleaned couple things.
>>>This is a better set
>>
>>Pavel, can you check if the API would allow you to use libini_config
>>instead of augeas?
>>
>
>For some reason the patches are not directly applicable by git. I had to
>remove the first character '>' from each patch before applying. After
that,
>it cannot be applied to the ding-libs master, it fails with:
>
>error: patch failed: Makefile.am:251
>error: Makefile.am: patch does not apply
>Patch failed at 0009 Build new interface
>
>Are those patches dependent on some other patches?
>
>Anyway, the interface should be good. I guess that the only thing I am
>missing from augeas functionality is the save function.
I am puzzled how ">" ended up in all the patches.
I regenerated a new set and there is no ">" there.
Also you are right. I have a patch that is in my tree since for me autotools
do not work with the current Makefile.am. I had to make a one line change but
it is close to the place where I did other change so patch 9 might not apply
cleanly. To avoid that I moved the lines around and generated a new version
of patch 9. I hope it would apply cleanly.
Thanks for checking!
The save part will be done as a part of the fileobj API. It will include
functions like:
- save backup in the given location
- change file ownership/permissions
- save file
--
Thank you,
Dmitri Pal
Sr. Engineering Manager IdM portfolio
Red Hat, Inc.
Just for the record
Patches from this thread are supperseded by paches from thread [1]
"[INI] Patches for the INI configuration modification"
LS
[1]
https://lists.fedorahosted.org/pipermail/sssd-devel/2015-January/022087.html