-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/23/2010 01:10 PM, Simo Sorce wrote:
On Tue, 23 Mar 2010 11:59:22 +0100
Jakub Hrozek <jhrozek(a)redhat.com> wrote:
> +
> + cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd,
> + tctx->octx->name);
> + if (!cmd) {
Nack,
if you do it this way you must shell escape the username.
It's probably better to use fork/exec on our own, so you can precisely
control the arguments w/o worrying about shell special characters.
Simo.
Thanks for the review, a new patch is attached
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkuqGGAACgkQHsardTLnvCVMfQCg1O50TYbmZ/JmT88wkAiNPJU3
Lb8An2suM0Nha4PwUSq+FsLX87FH8/jo
=+UIu
-----END PGP SIGNATURE-----