-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Fixes: #229
On Tue, 23 Mar 2010 11:59:22 +0100 Jakub Hrozek jhrozek@redhat.com wrote:
- cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd,
tctx->octx->name);
- if (!cmd) {
Nack, if you do it this way you must shell escape the username.
It's probably better to use fork/exec on our own, so you can precisely control the arguments w/o worrying about shell special characters.
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/23/2010 01:10 PM, Simo Sorce wrote:
On Tue, 23 Mar 2010 11:59:22 +0100 Jakub Hrozek jhrozek@redhat.com wrote:
- cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd,
tctx->octx->name);
- if (!cmd) {
Nack, if you do it this way you must shell escape the username.
It's probably better to use fork/exec on our own, so you can precisely control the arguments w/o worrying about shell special characters.
Simo.
Thanks for the review, a new patch is attached
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/24/2010 09:49 AM, Jakub Hrozek wrote:
On 03/23/2010 01:10 PM, Simo Sorce wrote:
On Tue, 23 Mar 2010 11:59:22 +0100 Jakub Hrozek jhrozek@redhat.com wrote:
- cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd,
tctx->octx->name);
- if (!cmd) {
Nack, if you do it this way you must shell escape the username.
It's probably better to use fork/exec on our own, so you can precisely control the arguments w/o worrying about shell special characters.
Simo.
Thanks for the review, a new patch is attached
Nack.
You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing them with errno return codes.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/31/2010 08:58 PM, Stephen Gallagher wrote:
Nack.
You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing them with errno return codes.
Ah, correct, thank you.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/01/2010 03:44 AM, Jakub Hrozek wrote:
On 03/31/2010 08:58 PM, Stephen Gallagher wrote:
Nack.
You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing them with errno return codes.
Ah, correct, thank you.
Ack.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/01/2010 07:48 AM, Stephen Gallagher wrote:
On 04/01/2010 03:44 AM, Jakub Hrozek wrote:
On 03/31/2010 08:58 PM, Stephen Gallagher wrote:
Nack.
You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing them with errno return codes.
Ah, correct, thank you.
Ack.
Pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org