-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/21/2009 02:15 PM, Sumit Bose wrote:
On Tue, Oct 20, 2009 at 07:20:51PM -0400, Simo Sorce wrote:
>
> On Tue, 2009-10-20 at 14:24 +0200, Sumit Bose wrote:
>> + dummy = dp_opt_get_cstring(opts, KRB5_CHANGEPW_PRINC);
>> + if (strchr(dummy, '@') == NULL) {
>> + value = talloc_asprintf(opts, "%s@%s", dummy, realm);
>> + if (value == NULL) {
>> + DEBUG(7, ("talloc_asprintf failed.\n"));
>> + return ENOMEM;
>> + }
>
> Same here too.
> Please always check what you get back.
>
> Simo.
>
ok, I've added checks where needed. New patches are attached.
bye,
Sumit
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
Ack to all.
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkrgY6EACgkQeiVVYja6o6MBbwCeKDJV388s9ymxB+17BiMrXPOJ
raAAnjtwkzQeLkv2Ggw+jViQTAJ/Uyt3
=fM4w
-----END PGP SIGNATURE-----