On Wed, Oct 21, 2009 at 08:51:21AM -0400, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/20/2009 08:24 AM, Sumit Bose wrote:
> Hi,
>
> this set of patches adds the new option handling to krb5 and ipa auth:
>
> 0001: new option handling for krb5
> 0002: new option handling for ipa auth
> 0003: fix a compiler warning that was introduced by extending
> krb5_common.h
>
> 0001 and 0002 depend on Simo's "Start implementing ipa specific
> options." patch.
>
> bye,
> Sumit
>
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
>
https://fedorahosted.org/mailman/listinfo/sssd-devel
Nack.
You commented out some code that should have been removed (elements of
krb5_ctx and their references in krb5_utils.c. Please remove them
removed
completely. This also causes the unit tests to fail:
'make check' fails:
../../server/tests/krb5_utils-tests.c: In function ‘setup_talloc_context’:
../../server/tests/krb5_utils-tests.c:67: error: ‘struct krb5_ctx’ has
no member named ‘realm’
../../server/tests/krb5_utils-tests.c:68: error: ‘struct krb5_ctx’ has
no member named ‘ccache_dir’
../../server/tests/krb5_utils-tests.c:46: warning: unused variable ‘ret’
ah, sorry, the test fixes were in another patch. It is now included in
0001.
Also, you use 'krb5_changepw_princ', but the manpage lists
'krb5_changepw_principle'. Please fix one or the other :)
it's 'krb5_changepw_principle'
I also changed the name of the DEBUG macro in 0003 and attached all
three patches again.
Thanks for the review.
bye,
Sumit