-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/03/2010 07:42 AM, Stephen Gallagher wrote:
On 09/03/2010 07:39 AM, Jan Zelený wrote:
> Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>> On 09/01/2010 05:56 AM, Jan Zelený wrote:
>>> Both your points are valid. I'm attaching a patch where the check is
>>> performed. I still think it is redundant, but it might be more safe in
>>> the future in case the code around it changes.
>>
>> Nack.
>>
>> This line:
>> dp_error = DP_ERR_FATAL;
>> is completely unnecessary. dp_error is never read again after this
>> assignment.
>>
>> I realize that it was there before this patch, but it's unnecessary and
>> wrong. Please remove it.
>>
>> The rest of the patch looks good.
> Thanks, I don't know how could I miss it. Now it is removed.
Ack.
Pushed to master.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEUEARECAAYFAkyGS9kACgkQeiVVYja6o6OtagCXZ/LqfgWEWlSwbv2YTCmqSoDN
CQCggMrhBUXGjvJKL0Wpze+ETofGAeg=
=NA5R
-----END PGP SIGNATURE-----