-----BEGIN PGP SIGNED MESSAGE-----
On 08/31/2010 05:41 AM, Jakub Hrozek wrote:
On 08/31/2010 09:59 AM, Jan Zelený wrote:
> I'm attaching some patches fixing various minor issues found by clang:
> Ticket: #577
> Ticket: #578
> Ticket: #579
Provided that it is safe to pass a NULL pointer to fprintf(), this is
OK. I know that glibc handles this, but I'm not entirely sure if that it
is good behaviour (if this would work with all possible optimalizations)
and if other libc implementations behave the same as glibc.
This is a bug in e.g. the Intel compiler, if I remember correctly.
Please fix fprintf. I recommend using the construct:
name ? name : "";
in the fprintf call.
> Ticket: #580
I guess NSS_STATUS_UNAVAIL is as good as any of the others in this case,
I don't understand this comment, Jakub. Jan used NSS_STATUS_TRYAGAIN
here (which I think is certainly correct).
> Ticket: #582
I think we should check for potential errors from sdap_id_op_done()
calls instead of removing the assignments altogether.
I agree with Jakub. These assignments shouldn't be removed, they should
be tested for failures.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----