[PATCH] NSS: fix a use-after-free issue
by Sumit Bose
Hi,
I found this accidentally because I was still running SSSD with
MALLOC_PERTURB_ set which I used some time ago to hunt a glibc issue.
This issue wasn't caught before by the unit-tests because
sss_cmd_done() which frees the context is overwritten in the tests and
so far didn't free the context. Additionally, since the use after free
was in a debug message, the unit tests must be run with debugging enable
to run over it. I think this is also the reason why Coverity or Clang
didn't found this issue before. Does anyone know if it is possible to
tell Converity to assume debug_level is set to 10?
bye,
Sumit
7 years, 7 months
[PATCH] BUILD: Fix cleanup without NLS
by Lukas Slebodnik
ehlo,
Manual pages were not cleaned by default.
They were cleaned in make distcheck because USE_NLS was enabled.
Reproducer:
cd src/man
make
make clean
# directory should contain generated manual pages
ls *.[1-8]
pam_sss.8 sssd_krb5_locator_plugin.8 sss_override.8
sss_cache.8 sssd-ldap.5 sss_rpcidmapd.5
sssd.8 sssd-simple.5 sss_seed.8
sssd-ad.5 sssd-sudo.5 sss_ssh_authorizedkeys.1
sssd.conf.5 sss_groupadd.8 sss_ssh_knownhostsproxy.1
sss_debuglevel.8 sss_groupdel.8 sss_useradd.8
sssd-ifp.5 sss_groupmod.8 sss_userdel.8
sssd-ipa.5 sss_groupshow.8 sss_usermod.8
sssd-krb5.5 sss_obfuscate.8
or alternative reproducer
make distcheck V=0 AUX_DISTCHECK_CONFIGURE_FLAGS=" --disable-nls"
LS
7 years, 7 months
[PATCH] DEBUG: Don't error on chown of nonexistent file
by Stephen Gallagher
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
We get an error message if we start up SSSD and the debug log does not
yet exist.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlYvgJsACgkQeiVVYja6o6PsvgCfUj+BFPTavtddwIcT8uoCAVpL
2AwAnirJFDFasy+zTf+mGeNCHDwK2ZtE
=g977
-----END PGP SIGNATURE-----
7 years, 7 months
[PATCH] Monitor: Show service pings at debug level 8
by Stephen Gallagher
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
SSSDBG_CONF_SETTINGS is reserved for configuration information. These
pings are generally just noise (when they fail, this is logged at
SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlYvgvQACgkQeiVVYja6o6NeVQCgocyUqrHud6p+KyyDULRdtx+/
Vj0AoIEfXJAbEgwDEgAmDJBuRLNv0v+n
=h2IT
-----END PGP SIGNATURE-----
7 years, 7 months