[PATCH] BUILD: Link just libsss_crypto with crypto libraries
by Lukas Slebodnik
ehlo,
Attached patch should prevent such failures as in commit
73ec8fdfddb2d4bf99977f758eec80e1b1ee8542
BUILD: Link test_data_provider_be with -ldl
SSS_CRYPT_LIBS should not be part of SSSD_LIBS.
all necessary program and libraries should be linked with
libsss_cryto.so an do not use SSS_CRYPT_LIBS directly.
LS
7 years, 5 months
More upstream CI tests
by Jakub Hrozek
Hi,
as we're stabilizing the 1.13 branch and before we plan what we want to
work on during the 1.14 development, we should use that time to write
some more tests!
Here are some areas where we could add tests. Please discuss or add your
ideas, I would like to turn this list into tickets we can start
implementing:
* Extend the LDAP provider tests with more dynamic test cases.
- add a user to a group, run sss_cache, assert id user displays the
new group and getent group displays the new member
- conversely with removing users from groups
* Background refresh
- could be built atop the LDAP NSS tests as well. I think we have
all the infrastructure in place.
* Local overrides integration test:
- this could be relatively easy, just call the overrides tool and
request the entry. Could be built atop the existing LDAP tests
or even use the local provider.
* Add a KDC
- until we have a pam_wrapper, this would only be useful to test
ldap_child, but adding the KDC instantiation might be worth it
nonetheless
- there is a protorype of KDC instantiation on the list for some
time now, since we enabled rootless SSSD
* IFP - could we reuse the existing sbus tests to spawn a custom bus?
* SUDO - can we trick sudo into connecting to our test sssd instance?
I think the order of priority is roughly as above. I think the LDAP
provider is critical enough to be well tested. The refresh and local
override tests might be nice to have because we would be refactoring the
NSS responder in 1.14, so we should have it tested.
I'll be happy to hear other opionions, though!
7 years, 5 months
[PATCH] man: Minor fixes to filter_groups description
by Nikolai Kondrashov
Hi everyone,
I noticed one little thing was wrong with the combined
filter_users/filter_groups description on the sssd.conf(5) manpage and also
wanted to add a note WRT nested groups behavior with filter_groups which was a
bit surprising to me. The trivial patches are attached.
Nick
7 years, 5 months
[PATCH] IPA: Check connection validity explicitly
by Jakub Hrozek
Hi,
the attached patch (hopefully) fixes
https://fedorahosted.org/sssd/ticket/2810
(gdb) bt
#0 0x00007f9e8dde21d7 in ipa_get_ad_acct_send (ar=0x7f9e9cc2ff80, override_attrs=0x0, be_req=<optimized out>, ipa_ctx=<optimized out>, ev=0x7f9e9cbf0670, mem_ctx=<optimized out>)
at src/providers/ipa/ipa_subdomains_id.c:648
#1 ipa_srv_ad_acct_lookup_step (req=req@entry=0x7f9e9cc81860) at src/providers/ipa/ipa_subdomains_id.c:1426
#2 0x00007f9e8dde2fbd in ipa_srv_ad_acct_send (ar=<optimized out>, override_attrs=<optimized out>, be_req=0x7f9e9ec9c400, ipa_ctx=0x7f9e9cc1c300, ev=0x7f9e9cbf0670, mem_ctx=<optimized out>)
at src/providers/ipa/ipa_subdomains_id.c:1406
#3 ipa_subdomain_account_get_original_step (req=req@entry=0x7f9e9cc69c60, ar=<optimized out>) at src/providers/ipa/ipa_subdomains_id.c:277
#4 0x00007f9e8dde35d1 in ipa_subdomain_account_got_override (subreq=0x0) at src/providers/ipa/ipa_subdomains_id.c:254
#5 0x00007f9e8dde9f9a in ipa_get_ad_override_done (subreq=0x0) at src/providers/ipa/ipa_views.c:414
#6 0x00007f9e8d4f49b5 in generic_ext_search_handler (subreq=0x0, opts=<optimized out>) at src/providers/ldap/sdap_async.c:1662
#7 0x00007f9e8d4f6592 in sdap_get_generic_op_finished (op=<optimized out>, reply=<optimized out>, error=<optimized out>, pvt=<optimized out>) at src/providers/ldap/sdap_async.c:1546
#8 0x00007f9e8d4f599d in sdap_process_message (ev=<optimized out>, sh=<optimized out>, msg=0x7f9e9dc833e0) at src/providers/ldap/sdap_async.c:352
#9 sdap_process_result (ev=<optimized out>, pvt=<optimized out>) at src/providers/ldap/sdap_async.c:196
#10 0x00007f9e9825e30b in epoll_event_loop_once () from /lib64/libtevent.so.0
#11 0x00007f9e9825c7d7 in std_event_loop_once () from /lib64/libtevent.so.0
#12 0x00007f9e98258fbd in _tevent_loop_once () from /lib64/libtevent.so.0
#13 0x00007f9e9825915b in tevent_common_loop_wait () from /lib64/libtevent.so.0
#14 0x00007f9e9825c777 in std_event_loop_wait () from /lib64/libtevent.so.0
#15 0x00007f9e9bb92853 in server_loop (main_ctx=0x7f9e9cbf1ac0) at src/util/server.c:668
#16 0x00007f9e9c407d52 in main (argc=8, argv=<optimized out>) at src/providers/data_provider_be.c:3005
(gdb) p clist
$1 = (struct sdap_id_conn_ctx **) 0x7f9e9dc89ba0
(gdb) p clist[0]
$2 = (struct sdap_id_conn_ctx *) 0x7f9e9cc72ee0
(gdb) p clist[1]
$3 = (struct sdap_id_conn_ctx *) 0x0
(gdb)
I don't have a good idea how to reproduce except simulate the failure in
gdb, sorry... at least I verified that after setting the context to NULL:
(gdb) set clist[1] = 0
the request runs to completion and SSSD doesn't crash anymore. So I think
we should just add a check..
I tried to set the AD server offline and do some lookups, but the context
was always initialized for me..
7 years, 5 months
[WIKI] Contribute and DevelTips are duplicate
by Petr Cech
Hi,
I've read the wiki according to
# https://fedorahosted.org/sssd/ticket/2706
and I think that it could be helpful clean the page
# https://fedorahosted.org/sssd/wiki/DevelTutorials
from "git topic" and create new page for everything related to git.
The motivation is, that:
* Contribute briefly describe whole process on basic level,
* DevelTips looks like How To,
* DevelTutorials are more about technologies, libraries, build process...,
* So there could be one page for everything about git.
--------------------------------------------------------------------------------
NOTES how we could edit wiki:
--------------------------------------------------------------------------------
https://fedorahosted.org/sssd/wiki/Contribute
Contribute
Contribution Policy
Source Code Repository /*
* There could be only a link to the
repo and
* reference to "New Git page".
*/
Tips and tricks for developers
QA, Development and Bug Triage
Development Repositories
Localization and Internationalization
Design Pages
Credits
Latest Documentation and Presentations
https://fedorahosted.org/sssd/wiki/DevelTips
SSSD Devel page
Are there any introductory tutorials available?
/* + Reference to the new "Git page" */
When I debug an SSSD process in a debugger, it always gets
killed with …
Using valgrind to identify memory access problems
Using strace to track the SSSD processes
How do I track work-in-progress of other developers? /*
* Is it
* still valid?
*
* I tried link
* for jhrozek and
* his sssd.git
* and the url
* doesn't exist.
*/
Why does make check take so long?
Using clang to perform static analysis of source code
When I compile the SSSD from source there is an error that says …
https://fedorahosted.org/sssd/wiki/DevelTutorials
/*
* Label @new-git-page means
* that I would like move given paragraph to the "New git page"
*/
Talloc
Tevent and tevent_req
Coding Style
Code Contributions /* @new-git-page */
Getting the source /* @new-git-page */
Building SSSD for development and debugging
Unit tests
Submitting a patch upstream /* @new-git-page */
Patch metadata /* @new-git-page */
Translation Contributions
Devel Tips
"New Git page" /* Maybe Git Tips? */
+ paragraph about git setup from Contribute->Source Code Repository
+ some paragraphs of DevelTutorials->Code Contributions
--------------------------------------------------------------------------------
I am looking forward your opinions.
Petr
7 years, 5 months