On (23/10/15 09:54), Pavel Reichl wrote:
On 10/23/2015 09:10 AM, Lukas Slebodnik wrote:
>On (22/10/15 13:35), Pavel Reichl wrote:
>>On 10/22/2015 12:27 PM, Pavel Březina wrote:
>>>On 10/22/2015 11:23 AM, Pavel Reichl wrote:
>>>>
>>>>
>>>>On 10/21/2015 12:44 PM, Pavel Březina wrote:
>>>>>On 10/21/2015 12:39 PM, Pavel Reichl wrote:
>>>>>>Hello,
>>>>>>
>>>>>>while reviewing integration tests for sss_override Nick noticed
that man
>>>>>>page does not mention restart requirements. Attached patch
(attempts to)
>>>>>>address that.
>>>>>>
>>>>>>Thanks!
>>>>>
>>>>>LGTM
>>>>
>>>>Pavel it seems to me that after calling user-del SSSD must be also
>>>>restarted, right?
>>>
>>>No. But you may be hitting memory cache.
>>
>>Oh, thanks. Please see updated patches.
>>
>>
>
>>From 073155493b06f3805f282843143a4a020e63bfbf Mon Sep 17 00:00:00 2001
>>From: Pavel Reichl <reichl.pavel(a)gmail.com>
>>Date: Wed, 21 Oct 2015 12:28:37 +0200
>>Subject: [PATCH 1/2] sss_override: Add restart requirements to man page
>>
>>---
>>src/man/sss_override.8.xml | 11 +++++++++--
>>1 file changed, 9 insertions(+), 2 deletions(-)
>>
>>diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
>>index
24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541 100644
>>--- a/src/man/sss_override.8.xml
>>+++ b/src/man/sss_override.8.xml
>>@@ -34,8 +34,15 @@
>> and groups. This change takes effect only on local machine.
>> </para>
>> <para>
>>- Overrides data are stored in SSSD cache. If the cache is deleted
>>- all local overrides are lost.
>>+ Overrides data are stored in the SSSD cache. If the cache is
deleted,
>>+ all local overrides are lost. Please note that after the first
>>+ override is created using any of the following
>>+ <emphasis>user-add</emphasis>,
<emphasis>group-add</emphasis>,
>>+ <emphasis>user-import</emphasis> or
>>+ <emphasis>group-import</emphasis> command. SSSD needs to
be
>>+ restarted to take effect.
>>+ <emphasis>sss_override</emphasis> prints message when a
restart is
>>+ required.
>> </para>
>> </refsect1>
>The patch is different iw we compare to the initial version.
>I think Dad deserves a credit so the author should be Dan.
>Will you prepare new patch or shoudl we change it before pushing.
Change the author before pushing then.
BTW do I deserve something for my effort? :-)
I filed many tickets for regressions
and it's not tracked anywhere.
So, do I deserve something for my effort? :-)
BTW2: second patch was not acked at all, first should be reacked.
I'm not the best person for review of man page changes.
So you might find reviewer somewhere else.
LS