[PATCH] IPA: Don't fail the request when BE doesn't find the object
by Jakub Hrozek
Hi,
see the attached patch. To reproduce, just run 'getent group
nosuchgroup(a)ad.trusted.domain' and make sure that with the patch
applied, groups_get_done() or users_get_done() also run and attempt to
delete the nonexistant user or group.
Additionally, there is a variable called user_dom in the codepath which
handles both users and group. Shall I rename it to obj_dom or similar?
9 years, 5 months
[PATCH] build: call AC_BUILD_AUX_DIR before anything else
by Jan Engelhardt
sssd's configure.ac (abridged) contains these lines:
AC_INIT([sssd], ...)
m4_ifdef([AC_USE_SYSTEM_EXTENSIONS],
[AC_USE_SYSTEM_EXTENSIONS], [AC_GNU_SOURCE])
AC_CONFIG_AUX_DIR([build])
When turned into configure, this will be emitted:
ac_aux_dir=
for ac_dir in build "$srcdir"/build; do
if test -f "$ac_dir/install-sh"; then
ac_aux_dir=$ac_dir
ac_install_sh="$ac_aux_dir/install-sh -c"
break
However, with automake commit v1.14.1-36-g7bc5927, this will be emitted
instead:
ac_aux_dir=
for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do
if test -f "$ac_dir/install-sh"; then
ac_aux_dir=$ac_dir
ac_install_sh="$ac_aux_dir/install-sh -c"
break
As configure no longer looks into build/ for install-sh, running
./configure fails:
configure: error: cannot find install-sh, install.sh,
or shtool in "." "./.." "./../.."
I think the error is that someone placed AC_BUILD_AUX_DIR
too late. Move it upwards.
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 660ea8d..e6745cb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4,6 +4,8 @@ m4_include([version.m4])
AC_INIT([sssd],
VERSION_NUMBER,
[sssd-devel(a)lists.fedorahosted.org])
+AC_CONFIG_SRCDIR([BUILD.txt])
+AC_CONFIG_AUX_DIR([build])
m4_ifdef([AC_USE_SYSTEM_EXTENSIONS],
[AC_USE_SYSTEM_EXTENSIONS],
@@ -11,8 +13,6 @@ m4_ifdef([AC_USE_SYSTEM_EXTENSIONS],
CFLAGS="$CFLAGS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE"
-AC_CONFIG_SRCDIR([BUILD.txt])
-AC_CONFIG_AUX_DIR([build])
AM_INIT_AUTOMAKE([-Wall foreign subdir-objects tar-pax])
AM_PROG_CC_C_O
--
2.0.0
9 years, 5 months
[PATCH] CI: Remove Clang analyzer
by Nikolai Kondrashov
Hi everyone,
The attached patch removes Clang analyzer run from CI as it takes a long time
and its results are ignored.
I initially expected it to be taken into use quickly, but as that is not
happening, we'd better remove it to save valuable CI server time.
We can always add it back when a solution to checking it is agreed on and
implemented.
Nick
9 years, 5 months
[PATCH] sdap_print_server: use getpeername() to get server address
by Sumit Bose
Hi,
I found this while looking at some logs. I think the intent of
sdap_print_server() is to print the IP address of the server SSSD is
connected to. If I understand it correctly to get this getpeername()
should be used, getsockname() will return the local IP address SSSD is
using to connect to the server.
bye,
Sumit
9 years, 5 months