[PATCH] MONITOR: Remove useless memory contexts
by Jakub Hrozek
Hi,
another small fix for the monitor code. I think the contexts come from
way ago when we supported online configuration changes, but to me, they
just make the code more confusing.
9 years, 6 months
Re: [SSSD] [PATCH] Suppress warning maybe-uninitialized
by Lukas Slebodnik
On (08/10/14 00:16), Simo Sorce wrote:
>On Tue, 7 Oct 2014 23:57:34 +0200
>Lukas Slebodnik <lslebodn(a)redhat.com> wrote:
>
>> - name = map[a].sys_name;
>> + name = map[i].sys_name;
>> + base_attr_idx = 1;
>
>this should be base_attr_idx = i; I think.
>
>
/me facepalms
fixed version attached.
LS
9 years, 6 months
[PATCH] DP: Print a type as hexadecimal number in debug message.
by Lukas Slebodnik
ehlo,
I was analysing log files for unrelated problem and I had to convert decimal
number to hexidecimalt to compare type in debug message in function
be_get_account_info. BE_REQ_* numbers are defined as hexadecimal in header file
src/providers/data_provider.h
Simple patch is attached.
LS
9 years, 6 months
[PATCH] Suppress warning maybe-uninitialized
by Lukas Slebodnik
ehlo,
There is a warning with some version of gcc (4.9.1, 4.4.7).
Warning is not visible with gcc 4.8
In my opinion, variable "a" should be initialized every time if
"maps" is not NULL.
src/providers/ldap/sdap.c: In function 'sdap_parse_entry':
src/providers/ldap/sdap.c:481:56: warning: 'a' may be used uninitialized in
this function [-Wmaybe-uninitialized]
for (ai = a; ai < attrs_num; ai++) {
^
src/providers/ldap/sdap.c:307:9: note: 'a' was declared here
int a, i, ret, ai;
^
CCLD libsss_ldap_common.la
You can also see warnin in koji build on fedora 21
https://kojipkgs.fedoraproject.org//packages/sssd/1.12.1/2.fc21/data/logs...
If you have better idea how to fix this warning I will be glad to review your
patch.
LS
9 years, 6 months
[PATCH] BUILD: Use $(MKDIR_P) in Makefile.am
by Jakub Hrozek
Hi,
While I was talking to the Fedora automake maintainer about an
enhancement related to test environment, he suggested to make the change
in the attached patch.
9 years, 6 months