URL:
https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after responder-induced refresh
finishes
jhrozek commented:
"""
On Wed, Dec 13, 2017 at 12:20:58PM +0000, mzidek-rh wrote:
I have a training today, so I am not sure if I will be able to review
and test this patch today or tomorrow, but I scrolled through the changes and they do make
sense.
Thanks for checking anyway and most of all, thank you for your help
during the tmate session on Monday.
Btw. I do not think it is good idea to trigger the (currently) periodic task to update
the subdomains by the responders. IMO this is provider specific thing and should stay in
the provider code. The code as is is not very easy to read and splitting the logic between
responder and provider would be another complication. So the way the patch is made now is
better IMO.
I think I wasn't clear, I wasn't proposing to move anything out of the
provider to the responder, I was just proposing removing the calls to
dp_reply_std_set() from the ipa_subdomains_handler_* request and create
a new request (which would be the IPA DP sudomains handler) which would
call ipa_subdomains_handler_* and dp_reply_std_set(). This way, the
ptask would behave as it does now, except the dp_reply_std_set().
"""
See the full comment at
https://github.com/SSSD/sssd/pull/470#issuecomment-351405233