URL:
https://github.com/SSSD/sssd/pull/484
Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem()
lslebodn commented:
"""
On (02/01/18 07:36), fidencio wrote:
fidencio commented on this pull request.
@sumit-bose, there's only one comment (made in-line) about this patch.
I'm firing internal CI, coverity, and so on.
I'll also do some manual tests later Today/this week.
> @@ -880,6 +880,8 @@ static int sdap_save_grpmem(TALLOC_CTX *memctx,
int ret;
const char *remove_attrs[] = {SYSDB_MEMBER, SYSDB_ORIG_MEMBER, SYSDB_GHOST,
NULL};
+ const char *check_dom;
+ const char *check_name;
@sumit-bose, sorry for nitpicking, but I'd prefer to have those two variables
initialized as NULL.
Can you see some warnings?
Could you explain the reason?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/484#issuecomment-354799672