On Mon, 2012-05-14 at 15:37 +0200, Sumit Bose wrote:
On Mon, May 14, 2012 at 08:52:16AM -0400, Simo Sorce wrote:
> On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote:
> > On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote:
> > > Hi,
> > >
> > > although we currently use the same internal representation for struct
> > > dom_sid as samba does this might not be the case in future. To avoid
> > > irritations this patch changes the name to struct sss_dom_sid.
> >
> >
> > This qualifies as an ABI break from the 1.9.0 beta 1 release.
>
> It's just an API break, not an ABI break unless you also change the
> structure signature.
>
> > I guess a
> > good question here is whether we need to bump the libsss_idmap.so
> > version.
>
> No.
>
> > Code-wise, Ack.
>
> Ack the same.
>
> Simo.
>
Thank you for review and comments. Since the version handling was broken
anyway and always ended up with 0:0:0 I attached a new patch which set
'-version-info 0:1:0'.
Ack. Also, just to be clear, this is NOT an SO name bump, it just
becomes libsss_idmap.so.0.0.1