ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
On Tue, Feb 17, 2015 at 04:43:45PM +0100, Lukas Slebodnik wrote:
ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
I'm curious how did you generate the patch?
Could a check like this be part of CI?
On (17/02/15 17:37), Jakub Hrozek wrote:
On Tue, Feb 17, 2015 at 04:43:45PM +0100, Lukas Slebodnik wrote:
ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
I'm curious how did you generate the patch?
Could a check like this be part of CI?
The patch was generated by clang based tool, but it requires JSON Compilation Database[1] and I would need to automate generation of that file (or convert it to clang plugin)
BTW The new lines were added by my tool and then I just slightly modified formatting of some debug messages.
LS
On Tue, Feb 17, 2015 at 05:56:04PM +0100, Lukas Slebodnik wrote:
On (17/02/15 17:37), Jakub Hrozek wrote:
On Tue, Feb 17, 2015 at 04:43:45PM +0100, Lukas Slebodnik wrote:
ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
I'm curious how did you generate the patch?
Could a check like this be part of CI?
The patch was generated by clang based tool, but it requires JSON Compilation Database[1] and I would need to automate generation of that file (or convert it to clang plugin)
BTW The new lines were added by my tool and then I just slightly modified formatting of some debug messages.
LS
Ah, awesome. Could you share how to generate the database? I'm a heavy user of YouCompleteMe: https://github.com/Valloric/YouCompleteMe#c-family-semantic-completion-engin...
Which works much better when the database is in place, which is normally the case for CMake-based projects.
On (17/02/15 16:43), Lukas Slebodnik wrote:
ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
Attached is updated version which remove extra new line added in logging of nsupdate message.
LS
On (18/02/15 09:45), Lukas Slebodnik wrote:
On (17/02/15 16:43), Lukas Slebodnik wrote:
ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
Attached is updated version which remove extra new line added in logging of nsupdate message.
LS
From fb63af5174b35f9f5f873a0be04cdc840eb1ac0b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Tue, 17 Feb 2015 16:40:01 +0100 Subject: [PATCH] Add missing new lines to debug messages
I send wrong patch which was not able to compile. src/providers/dp_dyndns.c: In function ‘be_nsupdate_create_ptr_msg’: src/providers/dp_dyndns.c:1207:0: error: unterminated argument list invoking macro "DEBUG" } ^ ../sssd/src/providers/dp_dyndns.c:525:5: error: ‘DEBUG’ undeclared (first use in this function) DEBUG(SSSDBG_TRACE_FUNC, ^ src/providers/dp_dyndns.c:525:5: note: each undeclared identifier is reported only once for each function it appears in src/providers/dp_dyndns.c:525:5: error: expected ‘;’ at end of input src/providers/dp_dyndns.c:525:5: error: expected declaration or statement at end of input src/providers/dp_dyndns.c:517:9: error: label ‘done’ used but not defined goto done; ^ src/providers/dp_dyndns.c:499:13: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable] errno_t ret; ^ src/providers/dp_dyndns.c:525:5: error: control reaches end of non-void function [-Werror=return-type] DEBUG(SSSDBG_TRACE_FUNC, ^ cc1: all warnings being treated as errors
LS
On 02/18/2015 10:32 AM, Lukas Slebodnik wrote:
On (18/02/15 09:45), Lukas Slebodnik wrote:
On (17/02/15 16:43), Lukas Slebodnik wrote:
ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
Attached is updated version which remove extra new line added in logging of nsupdate message.
LS From fb63af5174b35f9f5f873a0be04cdc840eb1ac0b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Tue, 17 Feb 2015 16:40:01 +0100 Subject: [PATCH] Add missing new lines to debug messages
I send wrong patch which was not able to compile. src/providers/dp_dyndns.c: In function ‘be_nsupdate_create_ptr_msg’: src/providers/dp_dyndns.c:1207:0: error: unterminated argument list invoking macro "DEBUG" } ^ ../sssd/src/providers/dp_dyndns.c:525:5: error: ‘DEBUG’ undeclared (first use in this function) DEBUG(SSSDBG_TRACE_FUNC, ^ src/providers/dp_dyndns.c:525:5: note: each undeclared identifier is reported only once for each function it appears in src/providers/dp_dyndns.c:525:5: error: expected ‘;’ at end of input src/providers/dp_dyndns.c:525:5: error: expected declaration or statement at end of input src/providers/dp_dyndns.c:517:9: error: label ‘done’ used but not defined goto done; ^ src/providers/dp_dyndns.c:499:13: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable] errno_t ret; ^ src/providers/dp_dyndns.c:525:5: error: control reaches end of non-void function [-Werror=return-type] DEBUG(SSSDBG_TRACE_FUNC, ^ cc1: all warnings being treated as errors
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html
On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote:
ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html
I fixed the space-before-newline mentioned in the other mail and pushed the patch to sssd-1-12: 7bc69afc71c0b8f48bdbf0b5b79d229a47aa49f2
On (18/02/15 16:18), Jakub Hrozek wrote:
On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote:
ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html
I fixed the space-before-newline mentioned in the other mail and pushed the patch to sssd-1-12: 7bc69afc71c0b8f48bdbf0b5b79d229a47aa49f2
All big patch sets were pushed to master. So it's time for patches for master branch.
LS
On (13/03/15 13:35), Lukas Slebodnik wrote:
On (18/02/15 16:18), Jakub Hrozek wrote:
On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote:
ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html
I fixed the space-before-newline mentioned in the other mail and pushed the patch to sssd-1-12: 7bc69afc71c0b8f48bdbf0b5b79d229a47aa49f2
All big patch sets were pushed to master. So it's time for patches for master branch.
It would be better to review patch before there will be conflict with another big patch set.
BTW: It was already review for branch sssd-1-12.
Thank you
LS
On Tue, Mar 17, 2015 at 12:59:53PM +0100, Lukas Slebodnik wrote:
On (13/03/15 13:35), Lukas Slebodnik wrote:
On (18/02/15 16:18), Jakub Hrozek wrote:
On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote:
ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html
I fixed the space-before-newline mentioned in the other mail and pushed the patch to sssd-1-12: 7bc69afc71c0b8f48bdbf0b5b79d229a47aa49f2
All big patch sets were pushed to master. So it's time for patches for master branch.
It would be better to review patch before there will be conflict with another big patch set.
ACK.
CI passed: http://sssd-ci.duckdns.org/logs/job/11/05/summary.html
I scrolled through the patch and the changes looked OK to me.
On Tue, Mar 17, 2015 at 02:38:27PM +0100, Jakub Hrozek wrote:
On Tue, Mar 17, 2015 at 12:59:53PM +0100, Lukas Slebodnik wrote:
On (13/03/15 13:35), Lukas Slebodnik wrote:
On (18/02/15 16:18), Jakub Hrozek wrote:
On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote:
ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html
I fixed the space-before-newline mentioned in the other mail and pushed the patch to sssd-1-12: 7bc69afc71c0b8f48bdbf0b5b79d229a47aa49f2
All big patch sets were pushed to master. So it's time for patches for master branch.
It would be better to review patch before there will be conflict with another big patch set.
ACK.
CI passed: http://sssd-ci.duckdns.org/logs/job/11/05/summary.html
I scrolled through the patch and the changes looked OK to me.
* master: * 95e98d7f620ee8200f960e7eeabd07d4dec1dca5 * 87f8bee53ee1b4ca87b602ff8536bc5fd5b5b595
On (17/03/15 14:46), Jakub Hrozek wrote:
On Tue, Mar 17, 2015 at 02:38:27PM +0100, Jakub Hrozek wrote:
On Tue, Mar 17, 2015 at 12:59:53PM +0100, Lukas Slebodnik wrote:
On (13/03/15 13:35), Lukas Slebodnik wrote:
On (18/02/15 16:18), Jakub Hrozek wrote:
On Wed, Feb 18, 2015 at 01:33:32PM +0100, Pavel Reichl wrote:
ci 1-12: http://sssd-ci.duckdns.org/logs/job/7/64/summary.html
I fixed the space-before-newline mentioned in the other mail and pushed the patch to sssd-1-12: 7bc69afc71c0b8f48bdbf0b5b79d229a47aa49f2
All big patch sets were pushed to master. So it's time for patches for master branch.
It would be better to review patch before there will be conflict with another big patch set.
ACK.
CI passed: http://sssd-ci.duckdns.org/logs/job/11/05/summary.html
I scrolled through the patch and the changes looked OK to me.
- master:
- 95e98d7f620ee8200f960e7eeabd07d4dec1dca5
- 87f8bee53ee1b4ca87b602ff8536bc5fd5b5b595
Thank you
LS
On 02/18/2015 09:45 AM, Lukas Slebodnik wrote:
On (17/02/15 16:43), Lukas Slebodnik wrote:
ehlo,
Attached patch should simplify analysis of log files. It should be applied to 1-12 branch. I will generate another version for master after merging all pending big patchsets.
LS
Attached is updated version which remove extra new line added in logging of nsupdate message.
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Patch fails to apply at master as you expected, so no CI has been run so far. But Nick is already working on CI support for 1-12.
Patch applies and builds fine on 1-12, I just noted one nitpick. But I think it is OK to ACK the patch as is.
+++ b/src/providers/ipa/ipa_hbac_rules.c @@ -144,7 +144,7 @@ ipa_hbac_rule_info_send(TALLOC_CTX *mem_ctx, ret = sysdb_attrs_get_string_array(ipa_host, SYSDB_ORIG_MEMBEROF, tmp_ctx, &memberof_list); if (ret != EOK && ret != ENOENT) {
DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify ");
DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify \n");
space before '\n'
} if (ret == ENOENT) { /* This host is not a member of any hostgroups */ memberof_list = talloc_array(tmp_ctx, const char *, 1);
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Pavel Reichl