On 02/18/2015 09:45 AM, Lukas Slebodnik wrote:
On (17/02/15 16:43), Lukas Slebodnik wrote:

Attached patch should simplify analysis of log files.
It should be applied to 1-12 branch. I will generate another version for master
after merging all pending big patchsets.

Attached is updated version which remove extra new line added
in logging of nsupdate message.


sssd-devel mailing list
Patch fails to apply at master as you expected, so no CI has been run so far. But Nick is already working on CI support for 1-12.

Patch  applies and builds fine on 1-12, I just noted one nitpick. But I think it is OK to ACK the patch as is.
+++ b/src/providers/ipa/ipa_hbac_rules.c
@@ -144,7 +144,7 @@ ipa_hbac_rule_info_send(TALLOC_CTX *mem_ctx,
     ret = sysdb_attrs_get_string_array(ipa_host, SYSDB_ORIG_MEMBEROF,
                                        tmp_ctx, &memberof_list);
     if (ret != EOK && ret != ENOENT) {
-        DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify ");
+        DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify \n");
space before '\n'
     } if (ret == ENOENT) {
         /* This host is not a member of any hostgroups */
         memberof_list = talloc_array(tmp_ctx, const char *, 1);