URL:
https://github.com/SSSD/sssd/pull/65
Title: #65: Fixing of nitpicks
jhrozek commented:
"""
On Tue, Oct 25, 2016 at 09:28:27AM -0700, lslebodn wrote:
lslebodn commented on this pull request.
> @@ -1104,7 +1104,6 @@ bool sss_krb5_realm_has_proxy(const char *realm)
kerr = profile_get_values(profile, profile_path, &list);
if (kerr == PROF_NO_RELATION || kerr == PROF_NO_SECTION) {
- kerr = 0;
goto done;
hmm,
```
sh$ $git show cbf20090fa92cc9a6e31e3c903b21d020c519367
tree cbf20090fa92cc9a6e31e3c903b21d020c519367
Sorry, I meant this one:
```
commit f0815f5dff315576c8d1b6fedf00165a4161f8c0
Author: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Fri Sep 4 10:30:03 2015 +0200
KRB5: Don't error out reading a minimal krb5.conf
With some setups, krb5.conf can be really minimal. In those cases, we
should ignore PROF_NO_RELATION and PROF_NO_SECTION and just return
"false" as in "no proxy" without a loud debug message.
Reviewed-by: Petr Cech <pcech(a)redhat.com>
diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c
index e29c753..2d2dfc4 100644
--- a/src/util/sss_krb5.c
+++ b/src/util/sss_krb5.c
@@ -1103,7 +1103,10 @@ bool sss_krb5_realm_has_proxy(const char *realm)
profile_path[1] = realm;
kerr = profile_get_values(profile, profile_path, &list);
- if (kerr != 0) {
+ if (kerr == PROF_NO_RELATION || kerr == PROF_NO_SECTION) {
+ kerr = 0;
+ goto done;
+ } else if (kerr != 0) {
DEBUG(SSSDBG_OP_FAILURE, "profile_get_values failed.\n");
goto done;
}
```
The commit message says that in that case we return false and even in retrospective it
makes sense to me because the config doesn't have any related information to
proxying.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/65#issuecomment-256683069