URL:
https://github.com/SSSD/sssd/pull/65
Title: #65: Fixing of nitpicks
lslebodn commented:
"""
On (08/11/16 05:26), celestian wrote:
celestian commented on this pull request.
> @@ -269,6 +269,10 @@ static void rdp_message_send_and_reply_done(DBusPendingCall
*pending,
sbus_req = talloc_get_type(ptr, struct sbus_request);
ret = rdp_process_pending_call(sbus_req, pending, &reply);
+ if (ret != EOK) {
+ /* Something bad happened. Just kill the request. */
+ goto done;
+ }
if (reply == NULL) {
I don't insist on the patch ```RESPONDER: Adding of return value checking```.
The patch is not absolutelly wrong.
But following check for NULL is redundant.
As I previously wrote, we should be consistent.
We shoudl either check `ret != EOK` after each invovation of
`rdp_process_pending_call` or we should check `reply == NULL`.
Ask @pbrezina why he wrote the code in such way.
LS
"""
See the full comment at
https://github.com/SSSD/sssd/pull/65#issuecomment-259138069