[sssd PR#811][opened] winbind idmap plugin: update struct idmap_domain to latest version
URL: https://github.com/SSSD/sssd/pull/811 Author: sumit-bose Title: #811: winbind idmap plugin: update struct idmap_domain to latest version Action: opened
PR body: """ While updating to interface version 6 we forgot to add the query_user member.
Recent version of Samba added a new member dom_sid. Unfortunately the interface version was not update for this change so we have to enable the member based on the Samba version.
Related to https://pagure.io/SSSD/sssd/issue/4005 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/811/head:pr811 git checkout pr811
URL: https://github.com/SSSD/sssd/pull/811 Title: #811: winbind idmap plugin: update struct idmap_domain to latest version
jhrozek commented: """ Actually, there was a compilation warning with this patch: ``` Error: COMPILER_WARNING: sssd-2.1.1/src/lib/winbind_idmap_sss/winbind_idmap_sss.c:28: included_from: Included from here. sssd-2.1.1/src/lib/winbind_idmap_sss/winbind_idmap_sss.h:85:35: warning: 'struct wbint_userinfo' declared inside parameter list will not be visible outside of this definition or declaration # struct wbint_userinfo *info); # ^~~~~~~~~~~~~~ # 83| #if SMB_IDMAP_INTERFACE_VERSION == 6 # 84| NTSTATUS (*query_user)(struct idmap_domain *domain, # 85|-> struct wbint_userinfo *info); # 86| #endif # 87| uint32_t low_id; ``` """
See the full comment at https://github.com/SSSD/sssd/pull/811#issuecomment-490939111
URL: https://github.com/SSSD/sssd/pull/811 Author: sumit-bose Title: #811: winbind idmap plugin: update struct idmap_domain to latest version Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/811/head:pr811 git checkout pr811
URL: https://github.com/SSSD/sssd/pull/811 Title: #811: winbind idmap plugin: update struct idmap_domain to latest version
sumit-bose commented: """ Hi Jakub,
thanks for checking, I guess I should move to a more recent version than F25 for development to get better warnings. The new version should fix the issue.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/811#issuecomment-490956885
URL: https://github.com/SSSD/sssd/pull/811 Title: #811: winbind idmap plugin: update struct idmap_domain to latest version
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/811 Title: #811: winbind idmap plugin: update struct idmap_domain to latest version
jhrozek commented: """
master: 30734e5 sssd-1-16: e673478
"""
See the full comment at https://github.com/SSSD/sssd/pull/811#issuecomment-492798617
URL: https://github.com/SSSD/sssd/pull/811 Author: sumit-bose Title: #811: winbind idmap plugin: update struct idmap_domain to latest version Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/811/head:pr811 git checkout pr811
URL: https://github.com/SSSD/sssd/pull/811 Title: #811: winbind idmap plugin: update struct idmap_domain to latest version
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
jhrozek -
sumit-bose