URL: https://github.com/SSSD/sssd/pull/803 Author: alexey-tikhonov Title: #803: TESTS: ability to run unit tests under valgrind Action: opened
PR body: """ Adds ability to run unit tests under valgrind with handy makefile targets. Enabled with --enable-valgrind passed to ./configure script. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/803/head:pr803 git checkout pr803
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented: """ retest this please """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-480937824
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
pbrezina commented: """ I get this error with all tests when I run it from different build directory. ``` ==8781== FATAL: can't open suppressions file "../contrib/ci/sssd.supp" ``` """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487522147
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/803 Author: alexey-tikhonov Title: #803: TESTS: ability to run unit tests under valgrind Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/803/head:pr803 git checkout pr803
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented: """
I get this error with all tests when I run it from different build directory.
==8781== FATAL: can't open suppressions file "../contrib/ci/sssd.supp"
Thanks. Hopefully fixed. """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487694750
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
pbrezina commented: """ Thank it works. The test fails though, it should be fixed before pushing this commit.
``` # TOTAL: 97 # PASS: 84 # SKIP: 0 # XFAIL: 0 # FAIL: 13 # XPASS: 0 # ERROR: 0 ``` """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487854595
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
pbrezina commented: """ Thanks it works. The test fails though, it should be fixed before pushing this commit.
``` # TOTAL: 97 # PASS: 84 # SKIP: 0 # XFAIL: 0 # FAIL: 13 # XPASS: 0 # ERROR: 0 ``` """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487854595
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented: """
Thanks it works. The test fails though, it should be fixed before pushing this commit.
Actually there are several tools used and on my machine results are: memcheck: clean drd: FAIL: 22 helgrind: FAIL: 15 sgcheck: FAIL: 8
For which tool do you have "# FAIL: 13" ?
Do we really need all tools clean? Primary goal of this PR to have convenient way to run memcheck tool. """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487915755
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented: """
Thanks it works. The test fails though, it should be fixed before pushing this commit.
Actually there are several tools used and on my machine results are: memcheck: clean drd: FAIL: 22 helgrind: FAIL: 15 sgcheck: FAIL: 8
For which tool do you have "# FAIL: 13" ?
Do we really need all tools clean? Primary goal of this PR to have convenient way to run memcheck tool (i.e. `make check-valgrind-memcheck`). """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487915755
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
jhrozek commented: """ +1 for only memcheck. """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487919268
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
pbrezina commented: """ I run just `make check && make check-valgrind`. """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487919551
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
pbrezina commented: """ `make check-valgrind-memcheck` is indeed clean. """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487920078
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented: """
I run just `make check && make check-valgrind`.
`make check-valgrind` does all tools. Results are in: ``` test-suite-drd.log test-suite-helgrind.log test-suite-memcheck.log test-suite-sgcheck.log ```
"""
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487924572
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
pbrezina commented: """ `make check-valgrind-memcheck` is clean and the patch works. I agree that it is not necessary to clean up the other checks. At least for now.
Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-487930719
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
jhrozek commented: """ * master: e812151511f7b09908efb3c8ebed294a26efebc7
By the way, @alexey-tikhonov do you want the patch to be backported to sssd-1-16 as well? Do you think our CI should be calling these targets? """
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-488076857
URL: https://github.com/SSSD/sssd/pull/803 Author: alexey-tikhonov Title: #803: TESTS: ability to run unit tests under valgrind Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/803/head:pr803 git checkout pr803
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented: """
By the way, @alexey-tikhonov do you want the patch to be backported to sssd-1-16 as well?
[PR](https://github.com/SSSD/sssd/pull/810)
Do you think our CI should be calling these targets?
memcheck: I think it "nice to have", but not something critical. Other tools: we need first clean up it.
"""
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-488679502
URL: https://github.com/SSSD/sssd/pull/803 Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented: """
By the way, @alexey-tikhonov do you want the patch to be backported to sssd-1-16 as well?
[PR](https://github.com/SSSD/sssd/pull/810)
Do you think our CI should be calling these targets?
memcheck: I think it is nice to rework CI to use makefile targets, but not something critical. Other tools: we need first clean up it.
"""
See the full comment at https://github.com/SSSD/sssd/pull/803#issuecomment-488679502
sssd-devel@lists.fedorahosted.org