URL: https://github.com/SSSD/sssd/pull/5343 Author: pbrezina Title: #5343: autofs: distinguish between empty cache and offline state Action: opened
PR body: """ If the cache is empty and SSSD is offline we now return a proper error code to autofs so it can iplement a proper retry logic to fetch the maps when SSSD comes back offline.
This also requires changes in autofs which are not yet available so the best way to test it with SSSD is to use the autofs test tool (autofs_test_client) to see that it returns correct error codes.
Resolves: https://github.com/SSSD/sssd/issues/3413 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5343/head:pr5343 git checkout pr5343
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
alexey-tikhonov commented: """
If the cache is empty and SSSD is offline we now return a proper error code to autofs so it can iplement a proper retry logic to fetch the maps when SSSD comes back offline.
This is, of course, out of SSSD scope, but what happens - currently and planned - if: `automount: db1 db2` and `db1` returns `EHOSTDOWN`? (IIUC, in case of `ENOENT` autofs would ask `db2`)
In some sense this is a change of API between autofs and plugin. Is this change backward compatible with autofs that doesn't implement proper handling of this error code yet?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-706388498
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
pbrezina commented: """ Even though autofs uses nsswitch.conf for database order, it does not use its logic (the autofs api is not part of glibc). But the [code](https://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git/tree/modules/...) suggest that it's going to fail, so I asked Ian once again in the bugzilla for reassurance. """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-717142798
URL: https://github.com/SSSD/sssd/pull/5343 Author: pbrezina Title: #5343: autofs: distinguish between empty cache and offline state Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5343/head:pr5343 git checkout pr5343
URL: https://github.com/SSSD/sssd/pull/5343 Author: pbrezina Title: #5343: autofs: distinguish between empty cache and offline state Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5343/head:pr5343 git checkout pr5343
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
pbrezina commented: """ I added _sss_auto_protocol_version to solve the circular dependency between autofs and SSSD, this is yet to be checked with Ian. """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-721761844
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
pbrezina commented: """ Ian approved these changes. Please continue with the review. Autofs test client got a new `-p number` parameter to set the requested protocol (`0 or 1`). """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-722296478
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
alexey-tikhonov commented: """ Thank you for the updates. I have some concerns wrt global var. Please see inline. """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-728005049
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5343 Author: pbrezina Title: #5343: autofs: distinguish between empty cache and offline state Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5343/head:pr5343 git checkout pr5343
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
alexey-tikhonov commented: """ btw, "pbrezina added 5 commits on Mar 6" - date looks weird... """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-732999477
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
pbrezina commented: """ :-) It's fine, I had the first patch set ready in March but it was blocked for a long time by Ian's work.
BTW RHEL7 and CentOS apparently does not have stdatomic.h (gcc 4.8 bug resolved in 4.9) so if we choose to use this we need to stop running prci against rhel7/centos7. I'm fine with that. """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-733028461
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
alexey-tikhonov commented: """
BTW RHEL7 and CentOS apparently does not have stdatomic.h (gcc 4.8 bug resolved in 4.9) so if we choose to use this we need to stop running prci against rhel7/centos7. I'm fine with that.
Perhaps we could add ./configure check for this header to error out gracefully.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-733870160
URL: https://github.com/SSSD/sssd/pull/5343 Author: pbrezina Title: #5343: autofs: distinguish between empty cache and offline state Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5343/head:pr5343 git checkout pr5343
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
pbrezina commented: """ Added. """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-734314556
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
alexey-tikhonov commented: """
Added.
It checks: ``` checking stdatomic.h usability... no checking stdatomic.h presence... no checking for stdatomic.h... no ``` but doesn't error out.
I would expect ./configure to stop here saying project won't build on this system? """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-734453092
URL: https://github.com/SSSD/sssd/pull/5343 Author: pbrezina Title: #5343: autofs: distinguish between empty cache and offline state Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5343/head:pr5343 git checkout pr5343
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
alexey-tikhonov commented: """ Thank you, ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-736003078
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5343
* `master` * 075519bceca7a8f4fa28a0b7c538f2f50d552d13 - configure: check for stdatomic.h * 8a22d4ad45f5fc8e888be693539495093c2b3c35 - autofs: correlate errors for different protocol versions * 34c519a4851194164befc150df8e768431e66405 - autofs: disable fast reply * 9098108a7142513fa04afdf92a2c1b3ac002c56e - autofs: translate ERR_OFFLINE to EHOSTDOWN * e50258da70b67ff1b0f928e2e7875bc2fa32dfde - autofs: return ERR_OFFLINE if we fail to get information from backend and cache is empty * 3f0ba4c2dcf9126b0f94bca4a056b516759d25c1 - cache_req: allow cache_req to return ERR_OFFLINE if all dp request failed
"""
See the full comment at https://github.com/SSSD/sssd/pull/5343#issuecomment-738715717
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5343 Title: #5343: autofs: distinguish between empty cache and offline state
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5343 Author: pbrezina Title: #5343: autofs: distinguish between empty cache and offline state Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5343/head:pr5343 git checkout pr5343
sssd-devel@lists.fedorahosted.org