URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Bz1734040 Action: opened
PR body: """
"""
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Bz1734040 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Bz1734040 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Bz1734040
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Bz1734040
sgoveas commented: """ Please resolve pep8 issue https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5410/2/rhel8/ci-pep8.log
To get more information, you can click on 'Details' against the test suite that failed.
Add clear summary message for the PR, you can provide more details, like the bug or ticket this code with test in the description section """
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732049132
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Bz1734040
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Bz1734040
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Bz1734040
ikerexxe commented: """ I think that you should also clone bugzilla ticket to github ticket and use the last one on the commit message. If you don't know how to do clone the ticket ping me on IRC (@ipedrosa). Moreover, commit message is not very clear, can you improve it following the template? ``` COMPONENT: Subject
Explanation
Resolves: https://github.com/SSSD/sssd/issues/XXXX ```
Finally, I think that you could squash all commits into one. """
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732057070
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Bz1734040
alexey-tikhonov commented: """
I think that you should also clone bugzilla ticket to github ticket and use the last one on the commit message
...
Resolves: https://github.com/SSSD/sssd/issues/XXXX
This is test automation, this patch itself doesn't resolve the issue. So I'm not sure if it's correct to state "resolves" here.
Moreover, usually BZ is already cloned to the upstream to the moment test is done (in this case this is #5295)
But I agree we should link those somehow. """
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732062219
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Bz1734040
ikerexxe commented: """
I think that you should also clone bugzilla ticket to github ticket and use the last one on the commit message ... Resolves: https://github.com/SSSD/sssd/issues/XXXX
This is test automation, this patch itself doesn't resolve the issue. So I'm not sure if it's correct to state "resolves" here.
Definitely `Resolves` is not the correct keyword here but there should be some link. Maybe `Test` or `Check` are better words.
Moreover, usually BZ is already cloned to the upstream to the moment test is done (in this case this is #5295)
Thanks for pointing the upstream ticket.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732231499
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Bz1734040 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Bz1734040 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Bz1734040 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Bz1734040 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Test: AD: For crash in ad_get_account_domain_search Action: edited
Changed field: title Original value: """ Bz1734040 """
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Test: AD: For crash in ad_get_account_domain_search Action: edited
Changed field: body Original value: """
"""
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Test: AD: For crash in ad_get_account_domain_search Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Test: AD: For crash in ad_get_account_domain_search Action: edited
Changed field: body Original value: """ Configures the AD domain and makes it unreachable by changing ad_domain parameter. Checks the request flag 0x0001 in log after sssd restart.
"""
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Test: AD: For crash in ad_get_account_domain_search Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Test: AD: For crash in ad_get_account_domain_search Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
sgoveas commented: """ Looks good to me """
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-736509208
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
ikerexxe commented: """ Let's wait for CI results but it also looks good to me. """
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-736529136
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5410
* `master` * 78ef0828dd745cbc55fc03cc42bd7ef26e70785e - Test: AD: For sssd crash in ad_get_account_domain_search
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-738720877
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5410 Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5410 Author: madhuriupadhye Title: #5410: Test: AD: For crash in ad_get_account_domain_search Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5410/head:pr5410 git checkout pr5410
sssd-devel@lists.fedorahosted.org