On Fri, Jul 01, 2016 at 01:24:35PM +0200, Pavel Březina wrote:
From 8b877579f3d1a9bbfa728a6e78ff829d936efbb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 1 Jul 2016 13:23:57 +0200 Subject: [PATCH] sssctl: print a message when managing sssd
Shouldn't this be specific to the service manager used? systemctl is quiet so this does add additional verbosity, but init scripts printed the starting/stopping message as well, so we would print them twice.
In general, I'm more in favor of tools being silent unless something goes bad.
On 07/05/2016 07:49 AM, Jakub Hrozek wrote:
On Fri, Jul 01, 2016 at 01:24:35PM +0200, Pavel Březina wrote:
From 8b877579f3d1a9bbfa728a6e78ff829d936efbb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 1 Jul 2016 13:23:57 +0200 Subject: [PATCH] sssctl: print a message when managing sssd
Shouldn't this be specific to the service manager used? systemctl is quiet so this does add additional verbosity, but init scripts printed the starting/stopping message as well, so we would print them twice.
In general, I'm more in favor of tools being silent unless something goes bad.
I think we should print something when we are doing more operations such as in remove-cache we are stopping and starting SSSD so I think it may be nice to tell administrator that we have actually stopped sssd but that we were unable to start it. But if you think we should stay silence and just print an error feel free to ignore this patch or tell me if I should make it systemd specific message.
On (07/07/16 12:59), Pavel Březina wrote:
On 07/05/2016 07:49 AM, Jakub Hrozek wrote:
On Fri, Jul 01, 2016 at 01:24:35PM +0200, Pavel Březina wrote:
From 8b877579f3d1a9bbfa728a6e78ff829d936efbb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 1 Jul 2016 13:23:57 +0200 Subject: [PATCH] sssctl: print a message when managing sssd
Shouldn't this be specific to the service manager used? systemctl is quiet so this does add additional verbosity, but init scripts printed the starting/stopping message as well, so we would print them twice.
In general, I'm more in favor of tools being silent unless something goes bad.
I think we should print something when we are doing more operations such as in remove-cache we are stopping and starting SSSD so I think it may be nice to tell administrator that we have actually stopped sssd but that we were unable to start it. But if you think we should stay silence and just print an error feel free to ignore this patch or tell me if I should make it systemd specific message.
Do we have some consensus to this patch?
LS
On 07/18/2016 01:28 PM, Lukas Slebodnik wrote:
On (07/07/16 12:59), Pavel Březina wrote:
On 07/05/2016 07:49 AM, Jakub Hrozek wrote:
On Fri, Jul 01, 2016 at 01:24:35PM +0200, Pavel Březina wrote:
From 8b877579f3d1a9bbfa728a6e78ff829d936efbb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 1 Jul 2016 13:23:57 +0200 Subject: [PATCH] sssctl: print a message when managing sssd
Shouldn't this be specific to the service manager used? systemctl is quiet so this does add additional verbosity, but init scripts printed the starting/stopping message as well, so we would print them twice.
In general, I'm more in favor of tools being silent unless something goes bad.
I think we should print something when we are doing more operations such as in remove-cache we are stopping and starting SSSD so I think it may be nice to tell administrator that we have actually stopped sssd but that we were unable to start it. But if you think we should stay silence and just print an error feel free to ignore this patch or tell me if I should make it systemd specific message.
Do we have some consensus to this patch?
Not really. I think we will drop it.
On (20/07/16 10:44), Pavel Březina wrote:
On 07/18/2016 01:28 PM, Lukas Slebodnik wrote:
On (07/07/16 12:59), Pavel Březina wrote:
On 07/05/2016 07:49 AM, Jakub Hrozek wrote:
On Fri, Jul 01, 2016 at 01:24:35PM +0200, Pavel Březina wrote:
From 8b877579f3d1a9bbfa728a6e78ff829d936efbb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 1 Jul 2016 13:23:57 +0200 Subject: [PATCH] sssctl: print a message when managing sssd
Shouldn't this be specific to the service manager used? systemctl is quiet so this does add additional verbosity, but init scripts printed the starting/stopping message as well, so we would print them twice.
In general, I'm more in favor of tools being silent unless something goes bad.
I think we should print something when we are doing more operations such as in remove-cache we are stopping and starting SSSD so I think it may be nice to tell administrator that we have actually stopped sssd but that we were unable to start it. But if you think we should stay silence and just print an error feel free to ignore this patch or tell me if I should make it systemd specific message.
Do we have some consensus to this patch?
Not really. I think we will drop it.
OK, I makrked the patch as rejected in patchwork
LS
sssd-devel@lists.fedorahosted.org