-----BEGIN PGP SIGNED MESSAGE-----
On 09/22/2010 04:04 AM, Sumit Bose wrote:
> - I think a toplevel m4 directory is missing and all m4
> the subdirectories can be removed.
Whoops, you're right. I missed that. Fixed.
> - The README file needs an update to reflect the changes.
> - there is an empty last line in version.m4
That's intentional. I never trust that any parser handles EOF gracefully
(because so many forget to)
> With the m4 directory changes I was able to run 'make
> rpms' and friends without any issue.
I also made a few additional changes that struck me while I was fixing
I noticed that I was packaging the wrong README file in %doc in dhash,
and I wasn't packaging the README for either ref_array or path_utils.
I changed the names of those files to README.dhash, etc. so that when
running 'make install' they would not overwrite each other. (Before,
when they were separate tarballs they would have been placed in a
New patch attached. Thank you for the review.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----