Stephen Gallagher wrote:
On 09/22/2010 07:20 AM, Stephen Gallagher wrote:
> On 09/22/2010 04:04 AM, Sumit Bose wrote:
>>> - I think a toplevel m4 directory is missing and all m4
directories from
>>> the subdirectories can be removed.
> Whoops, you're right. I missed that. Fixed.
>>> - The README file needs an update to reflect the changes.
> Fixed.
>>> - there is an empty last line in version.m4
> That's intentional. I never trust that any parser handles EOF gracefully
> (because so many forget to)
>>> With the m4 directory changes I was able to run 'make distcheck',
'make
>>> rpms' and friends without any issue.
> I also made a few additional changes that struck me while I was fixing
> the above.
> I noticed that I was packaging the wrong README file in %doc in dhash,
> and I wasn't packaging the README for either ref_array or path_utils.
> I changed the names of those files to README.dhash, etc. so that when
> running 'make install' they would not overwrite each other. (Before,
> when they were separate tarballs they would have been placed in a
> different path)
> New patch attached. Thank you for the review.
Dmitri noticed that we weren't generating the docs correctly. The
attached patch addresses this.
ACK
-------------------------
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
--
Thank you,
Dmitri Pal
Engineering Manager IPA project,
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/