On Fri, Apr 11, 2014 at 05:29:35PM +0200, Lukas Slebodnik wrote:
On (11/04/14 16:49), Jakub Hrozek wrote:
>On Fri, Apr 11, 2014 at 01:57:52PM +0200, Lukas Slebodnik wrote:
>> Why separe patch?
>> generated files should not in in tarball.
>
>Because a patch that fixes an issue important enough to trigger a release
>should be minimal. I would prefer to commit the part that touches the systemd
>service file in a separate patch, do the release and then apply the rest.
I split only patch for 1-11 branch.
LS
Thank you, I think that's fine, master is still in the early stages.
I already run some tests with a scratch build based on a tarball
generated with your previous patch:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6727883
And everything went fine. I will run some tests with the modified
mini-patch as well before acking, but the changes look good!