On Mon, Feb 27, 2012 at 03:02:59PM +0100, Jan Cholasta wrote:
Fixed what Jakub found in the review and a few other bugs.
Attached are 2 tarballs, one with patches for master, the other with
patches for sssd-1-8.
Patches for master are:
[PATCH 1/8] SSH: Don't abort known_hosts update when host search fails
Ack
[PATCH 2/8] SSH: Add more debugging messages
Ack
[PATCH 3/8] SSH: Add missing break statements to
sss_ssh_format_pubkey
Ack
[PATCH 4/8] SSH: Use fchmod instead of chmod on known_hosts file
If the talloc_strdup failed, you would try to unlink the template in the
"done" label.
[PATCH 5/8] SSH: Replace blocking getaddrinfo call in the responder
with asynchronous resolver code
Ack
[PATCH 6/8] SSH: Remove unused --file option of
sss_ssh_knownhostsproxy
Ack
[PATCH 7/8] SSH: Update sss_ssh_knownhostsproxy manual page
Please use the <filename> tag around /var/lib/sss/pubconf/known_hosts
[PATCH 8/8] SSH: Include SSH client source files to the list of
source files which contain translatable strings
Can you also add src/tools/sss_cache.c and src/tools/sss_debuglevel.c
for completeness ?
Patches for sssd-1-8 are the 5 patches pushed to master and the
patches above, without patch 8/8.
I'm reviewing these now. I suspect there will only be the same minor issues
in patches 4 and 6.