URL:
https://github.com/SSSD/sssd/pull/5539
Title: #5539: NSS: Clear negative cache when SIGHUP received
alexey-tikhonov commented:
"""
Thanks for the updates. This version definitely looks better and should do what is
functionally required.
What feels a little bit loose: patch relies on the order of method invocations in the
monitor to assure sss_cache is blocked until all operations are done. But I think proper
resolution should include decoupling of log rotation and cache reset, and since you said
you wouldn't like to do this within this PR, then proper comment would be enough.
As a more important note:
- instead of addition of a new method in "sssd.service" interface you could
check if it’s possible to reuse existing methods of
"sssd.Responder.NegativeCache"
- while not strictly necessary to be done within this PR, imo it also makes sense to do
the same with clearMemcache() method - either move it to “sssd.nss.MemoryCache” or just
get rid of it and reuse existing InvalidateAll*() (but the latter would require
verification that it does the same)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5539#issuecomment-808515095