On Fri, Oct 24, 2014 at 10:52:47PM +0200, Jakub Hrozek wrote:
On Mon, Oct 20, 2014 at 06:35:13PM +0200, Michal Židek wrote:
> On 10/20/2014 04:13 PM, Jakub Hrozek wrote:
> >Hi,
> >
> >I'll send patches that help SSSD run as a non-root user to this thread.
> >I'm still chasing some bugs in the krb5_child changes, but the attached
> >patches are ready for review.
> >
> >If other developers don't like the idea of a Python-based unit test that
> >spawns a KDC, I'm equally fine with keeping those patches in my tree --
> >they served their purpose, after all.
> >
> >
> >0001-BUILD-Install-ldap_child-and-krb5_child-as-setuid-if.patch
> >
>
> Ack.
>
> >
> >0002-LDAP-Move-sss_krb5_verify_keytab_ex-to-ldap_child.patch
> >
>
> Ack.
>
> >
> >0003-LDAP-read-the-correct-data-type-from-ldap_child-s-in.patch
> >
> > /* ticket lifetime */
> >- SAFEALIGN_COPY_INT32_CHECK(&ibuf->lifetime, buf + p, size, &p);
> >+ SAFEALIGN_COPY_UINT32_CHECK(&ibuf->lifetime, buf + p, size,
&p);
> > DEBUG(SSSDBG_TRACE_LIBS, "lifetime: %d\n", ibuf->lifetime);
> ^^^
> Should be %u. Otherwise Ack.
Fixed.
>
> >
> >0004-LDAP-Drop-privileges-after-kinit-in-ldap_child.patch
> >
>
> Ack.
>
Thank you for the review.
> >
> >0005-TESTS-Fix-krb5_child-test.patch
> >0006-TESTS-Add-a-cwrap-enabled-test-for-krb5_child.patch
I'm withdrawing these two patches for now. The krb5_child needs more
work and should be submitted with the krb5_child changes anyway.
The ldap_child patches are attached.
Hi,
I'm sorry, but I had one ldap_child change squashed into another
patch...
New patches are attached. Also the subject was changed to something more
appropriate.