On Fri, 2012-11-02 at 22:58 +0100, Pavel Březina wrote:
Ok if you are fixing indent also fix style while there please so we do
this once.
+ /* try and use up these file descriptors, so silly
+ library routines writing to stdout etc won't cause havoc */
+ for (i=0;i<3;i++) {
should be for (i = 0; i < 3; i++) {
+ fd = open("/dev/null",O_RDWR,0);
space after ,
+ if (fd < 0)
+ fd = open("/dev/null",O_WRONLY,0);
space after ,
+ if (fd < 0) {
+ DEBUG(0,("Can't open /dev/null\n"));
space after ,
+ return;
+ }
+ if (fd != i) {
+ DEBUG(0,("Didn't get file descriptor %d\n",i));
space after ,
+ return;
+ }
+ }
#endif
}
Also you can change the debug level from number to macro here, as it is
not a functional change IMO.
Also later there is at least one line longer than 80, would be nice to
fold that.
Simo.
--
Simo Sorce * Red Hat, Inc * New York