On Thu, 23 Sep 2010 14:02:20 -0400
Stephen Gallagher <sgallagh(a)redhat.com> wrote:
I'm not a huge fan of firing off all of the
calls in a loop for (effectively) simultaneous operation. I'd prefer
if you implemented this with our _step() approach (where you handle
each one serially until they're all finished). It's quite a bit
easier to follow in a debugger. This will also eliminate the need for
GROUPMEMBER_REQ_PARALLEL. Believe it or not, it won't be any slower
because the LDAP id op operations will serialize the requests anyway
so we don't open large numbers of separate connections to the LDAP
Steve, I agree with Ralf's approach here.
Yes it makes the code a bit more complex, but it will kill latency big
time. And latency is something that hurts us really bad.
Simo Sorce * Red Hat, Inc * New York