-----BEGIN PGP SIGNED MESSAGE-----
On 12/07/2009 09:21 AM, Stephen Gallagher wrote:
On 12/07/2009 09:19 AM, Sumit Bose wrote:
> On Mon, Dec 07, 2009 at 07:45:15AM -0500, Stephen Gallagher wrote:
>>>> 0002 adds sysdb calls to ipa_access if the provider is offline
> The memory allocation in msgs2attrs_array() looks wrong to me.
> You shouldn't be allocating an array into *a. You're overwriting it (and
> leaking memory) when you allocate a single sysdb_attrs pointer for a[i]
> anyway (and it would be correct there)
> Otherwise it looks fine.
>> ah, sorry that talloc_array was completely useless. I removed it.
Pushed both patches to master.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----