On 01/13/2014 09:32 AM, Lukas Slebodnik wrote:
On (13/01/14 08:55), Dmitri Pal wrote:
> On 01/13/2014 05:46 AM, Lukas Slebodnik wrote:
>> ehlo,
>>
>> Test negative_test was defined, but it has never been executed as part of
>> ini_config test suite.
>>
>> Simple patch is attached.
>>
>> LS
>>
> This unit test tests old interfaces that is being phased out.
> I do not think we need to improve UNIT test for the API that is
> deprecated. IMO sends a wrong message so I would rather drop this.
>
Yes,
it is testing old interface, but old interface is still part of library.
Unit test passes without any problem. Do we really need to remove this unit
test? Personally, I don't have problem with it.
LS
We need to remove unit test when we remove the old interface.
I do not think it is time yet to remove the interface.
But fixing unit test also does not seem like time well spent.
--
Thank you,
Dmitri Pal
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/