-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/06/2010 02:33 PM, Stephen Gallagher wrote:
On 04/06/2010 12:03 PM, Jakub Hrozek wrote:
> On 04/06/2010 04:34 PM, Stephen Gallagher wrote:
>> Sorry, I hate to say this, but I realized that killall returns nonzero
>> if there are no processes running by that user name. So this warning is
>> going to look wrong if we run the userdel command on a system where the
>> user isn't logged in. I withdraw my request for this warning.
>> Also, we probably need to do 'killall -9' rather than simply killall, as
>> SIGTERM doesn't terminate shell processes (which are the most important
>> ones to kill if we need to kick a user)
> Ah, correct. I only tested with ssh session where the kick worked fine.
> Thank you for the review, a new patch is attached.
Ack
Pushed to master.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAku7ftMACgkQeiVVYja6o6O/ZgCdGAYl17VK4d0bxtjc2vxsJ7HF
7LkAn1CZq2jWe3cyKmIzkL4hI8QosI6F
=7/Dg
-----END PGP SIGNATURE-----