On Thu, 2012-12-20 at 14:05 +0100, Ondrej Kos wrote:
Here are two patches for the SYSDB:
[PATCH 1/2] SYSDB: replace ghost users properly
this fixes
https://fedorahosted.org/sssd/ticket/1714
It seem that here you are basically scanning the whole attribute.
Instead of making potentially multiple deletes then wouldn't it be
easier to recompute the attribute and do a single replace omitting the
names you do not want in there?
I think you can significantly reduce the amount of linear searches as
the current patch introduces O(n^2) like behavior (nested linear loops).
Simo.
[PATCH 2/2] SYSDB: split sysdb_add_user
splits add_user code to more readable blocks
Patches are attached
--
Simo Sorce * Red Hat, Inc * New York