On 05/27/2015 02:44 PM, Nikolai Kondrashov wrote:
> On 05/27/2015 10:52 AM, Lukas Slebodnik wrote:
>> On (27/05/15 10:49), Nikolai Kondrashov wrote:
>>> On 05/27/2015 08:55 AM, Lukas Slebodnik wrote:
>>>> On (26/05/15 20:49), Nikolai Kondrashov wrote:
>>>>> On 05/26/2015 07:56 PM, Lukas Slebodnik wrote:
>>>>>> On (26/05/15 13:03), Nikolai Kondrashov wrote:
>>>>>>> Hmm, you asked me to change the "misc.py" name, but
now you're
>>>>>>> suggesting we
>>>>>>> should split it. Is it really worth it for three tiny
functions?
>>>>>>> What if we
>>>>>>> just rename it to "util.py", or some other name
which you find
>>>>>>> more suitable?
>>>>>>>
>>>>>> OK, it does not worth to block patches
>>>>>
>>>>> Thank you :) Would you still like me to rename the file?
>>>>>
>>>> Yes, please.
>>>
>>> So, should it be "util.py", or something else?
>>>
>> Yes.
>
> I assume you meant "util.py", then :)
>
> Alright, here is the fifth version of integration test patches.
> Changes from v4 include:
>
> * One less patch: HAVE_PYTHON2/3 conditionals are not added now.
> * Configure-time dependency checking is redone with just (AC_SUBST'ed)
> variables.
> * Configure-time dependency checking is moved into the "intgcheck" make
> target
> itself, so you don't need to specify "--enable-intgcheck" to use it
> anymore.
> Thanks for spotting this, Lukas!
> * The slapd setup now checks for the server ports to open, instead of just
> PID file being created, avoiding a racing condition and test failures
> occasionally seen on VMs.
> * fakeroot.m4 and pytest.m4 are merged into intgcheck.m4.
> * misc.py renamed to util.py.
>
> CI results:
>
http://sssd-ci.duckdns.org/logs/job/16/10/summary.html
>
> Nick
>
I talked to Lukas, offline. He said that he is OK with the build part now (thank you
Lukas for the comments). So the patches are fully ACKed now.
CI passed:
http://sssd-ci.duckdns.org/logs/job/16/26/summary.html
ACK to both patches.
Thank you both, Michal and Lukas, for the thorough review and useful comments
and suggestions! Hope this finally makes it into the public repo :)
Sincerely,
Nick