-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/30/2010 09:49 AM, Simo Sorce wrote:
On Fri, 30 Jul 2010 09:08:52 -0400
Stephen Gallagher <sgallagh(a)redhat.com> wrote:
> I've added a new patch
> 0005-Copy-the-attrs-attribute-in-sysdb_search_user_by_nam.patch that
> fixes this.
NACK, the unbspoken rule for teven stype stuff is that if you pass down
something to a _send() function it *has* to stay around until the
corresponding _recv() function is called. That's why usually things are
allocated on the "state" variable.
By copying it, not only we waste resources, we also set us up for
further failures elsewhere.
Simo.
I dropped the copy patch and changed the clean-up patch to allocate the
attrs on the state variable. Should be compliant with our style now.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkxS24MACgkQeiVVYja6o6MiyACePhKq4euvDbi6LPOcZORRJAyx
W6UAmwVc0Yv8ehwRML8j2nF5RqFIcZ4j
=f4PL
-----END PGP SIGNATURE-----