On Tue, Aug 05, 2014 at 03:39:11PM +0200, Lukas Slebodnik wrote:
On (28/07/14 10:14), Simo Sorce wrote:
>On Thu, 2014-07-24 at 21:18 +0200, Jakub Hrozek wrote:
>> On Thu, Jul 24, 2014 at 03:20:45PM -0400, Dan Lavu wrote:
>> > Was talking to Lukas about the name and came up with this suggestion,
>> >so instead of "whitespaces_replacement_string" to
"override_default_whitespace", thoughts?
>>
>> I like it!
>>
>> Dan, given you're a native speaker, would you mind taking a look at the
>> changes to src/man/sssd.conf.5.xml ?
>
>whitespace_substitute would be shorter.
>
>Simo.
>
If others agree, we can rename this configuration option. sssd was not
released officially with "override_default_whitespace" yet.
I would prefer to first discuss if we should replace all whitespace or
just "space". See:
https://fedorapeople.org/cgit/jhrozek/public_git/sssd.git/commit/?h=case
I'm sorry I didn't catch this earlier, only when I started working on
extending the functionality to other responders.
I personally favor safety and simplicity over functionality, so I think
it would be better to only replace space (as winbind does) to be able to
replace symetrically. I also realize the RFE talked about "whitespace"
but I believe that was a misunderstanding. I reached out to the original
reporter of the RFE for clarification..