On 04/30/2015 03:33 PM, Jakub Hrozek wrote:
On Thu, Apr 30, 2015 at 02:13:04PM +0200, Pavel Reichl wrote:
> Functionality of split_str() in actually not new. It's used in many places
> ad hoc as part of other functions.
(I haven't seen the code, just following the discussion)
Would it make sense to consolidate the code to use split_str(), then?
Well, it would be nice, but I'm afraid it's not worth the effort. For
example 'split_extra_attr()' uses quite similar code but not exactly the
same, it could be changed, but I don't think it's worth the risk of
In the posted patch I needed similar functionality so I could introduce
static helper function for this purpose or (as I did) make decision that
this is generally useful functionality that could be reused and move it
sssd-devel mailing list