Title: #215: Support for non-POSIX users and groups
fidencio commented:
"""
On Tue, Mar 28, 2017 at 11:14 PM, Jakub Hrozek <notifications(a)github.com>
wrote:
*@jhrozek* commented on this pull request.
------------------------------
In src/providers/ldap/ldap_id.c
<
https://github.com/SSSD/sssd/pull/215#discussion_r108538847>:
> @@ -292,7 +297,13 @@ struct tevent_req *users_get_send(TALLOC_CTX *memctx,
}
}
- if (state->use_id_mapping || filter_type == BE_FILTER_SECID) {
+ if (state->non_posix == true) {
+ state->filter = talloc_asprintf(state,
(btw as long as we agree that if (val) and if (!val) is used for bools
only then I think it's OK readability wise but I still prefer ptr != NULL
over !ptr
+1 here. I also prefer explicit checks for everything that's not boolean.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/SSSD/sssd/pull/215#discussion_r108538847>, or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AAG4eqh7BP99rMQWY4eKAuI...
.